fix: default stationary node when inserting a block #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-matt-hillsdon
requested review from
gonfunko
and removed request for
a team
It can be null if the workspace has never taken focus but it's unhelpful to behave as if the user had selected the workspace itself (as via 'w'). Use the same logic as the workspace would use if it had taken focus, which will return the first block. Fixes RaspberryPiFoundation#629
microbit-matt-hillsdon
force-pushed
the
fix-no-ws-focus-insert
branch
from
aed6c35 to
7f601f2
Compare
gonfunko
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be null if the workspace has never taken focus but it's unhelpful to behave as if the user had selected the workspace itself (as via 'w'). Use the same logic as the workspace would use if it had taken focus, which will return the first block.
Fixes #629
CC @BenHenning in case there's any downside to this I'm not seeing.