feat: duplicate shortcut for blocks and comments #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augment context menu entries from core with the shortcut text if present. Reorder initalization as we now require comment context menu actions to be registered first for this feature. Be defensive for folks that might already have such a shortcut.
microbit-matt-hillsdon
requested review from
maribethb
and removed request for
a team
| await this.browser.pause(PAUSE_TIME); | ||
| chai.assert.isTrue( | ||
| await contextMenuExists(this.browser, 'Duplicate'), | ||
| await contextMenuExists(this.browser, 'Collapse Block'), |
Contributor
Author
There was a problem hiding this comment.
Adding a shortcut to duplicate meant that these didn't match anymore. Simplest to switch to something else without a shortcut.
Contributor
Author
|
Fixed trivial import conflict with undo/redo action removal. |
maribethb
approved these changes
Jul 7, 2025
src/actions/duplicate.ts
Outdated
| return false; | ||
| }, | ||
| callback(workspace, e, shortcut, scope) { | ||
| const copiable = scope.focusedNode as ICopyable<ICopyData>; |
Collaborator
There was a problem hiding this comment.
can you spell this copyable for consistency?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment context menu entries from core with the shortcut text if present. Reorder initalization as we now require comment context menu actions to be registered first for this feature.
Be defensive for folks that might already have such a shortcut.
Fixes #591
Demo: https://duplicate.blockly-keyboard-experimentation.pages.dev/