test: move registerCommentOptions before plugin #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests so contextMenuExists does not care whether there's a shortcut defined. Separately assert the full context menu contents including shortcuts for blocks in the workspace and toolbox, workspace comments and the workspace itself. Fixes RaspberryPiFoundation#648
microbit-matt-hillsdon
requested review from
cpcallen
and removed request for
a team
Contributor
Author
|
Test failures due to spaces in the Windows/Linux option formats. Will fix shortly. |
Contributor
Author
Hopefully got this right in 824f059. Please approve re-run. |
cpcallen
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests so contextMenuExists does not care whether there's a shortcut defined.
Separately assert the full context menu contents including shortcuts for blocks in the workspace and toolbox, workspace comments and the workspace itself.
Add a space to separate the keyboard shortcut from the context menu label as it was only visually separated and a screen reader would have heard e.g. "DuplicateD".
Fixes #648