chore: remove unused ts expect error #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Unfortunately the rest of the test failures are because blockly is currently broken in this branch for renderers other than zelos. Prior to merging |
Collaborator
Author
|
Filed RaspberryPiFoundation/blockly#9367 I think it's useful to go ahead and merge this despite the remaining failures since the problem is in core, not this repo, tests will automatically pass again when that issue is fixed. |
1 task
Collaborator
Author
|
The problems with geras/thrasos were fixed in core so this now passes. |
BenHenning
approved these changes
Sep 16, 2025
maribethb
merged commit 59d4e8a
into
RaspberryPiFoundation:add-screen-reader-support-experimental
8 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is against the
add-screen-reader-support-experimentalbranch.Removes a ts-expect-error declaration because in the corresponding branch of blockly, that property is public. The unnecessary expect causes tests to fail to compile.