fix: Fix bug that caused blocks to be inserted into an immovable stack. #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
approved these changes
Sep 30, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko! Makes sense to me!
Contributor
Author
|
@RoboErikG pointed out that this bug still existed for input blocks. I've added another commit to address that scenario. PTAL @BenHenning |
BenHenning
approved these changes
Oct 1, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Latest changes still make sense, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #725. In cases where a statement block was selected and a new statement block was inserted, the new block would be proposed for connection to the selected block. If the selected block's next block is immovable however, this is invalid, because to splice the new block into the middle of an immovable block stack would move the subsequent blocks as a side effect. This PR verifies that the next connection is actually capable of connecting to the new block, and keeps looking down the stack until it finds an eligible connection or gives up.