feat: add getFirstNode and getLastNode to cursor with tests #8878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested review from
RoboErikG and
maribethb
and removed request for
RoboErikG
maribethb
approved these changes
Apr 11, 2025
rachel-fenichel
merged commit 3160e3d
into
RaspberryPiFoundation:rc/v12.0.0
8 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Progress on RaspberryPiFoundation/blockly-keyboard-experimentation#409
Proposed Changes
Add helpers that navigation and movement code can use to do loopback.
Test Coverage
The tests were the hardest part of this. I ran into an issue with our test tooling when handling equality comparisons and diffs of objects with circular dependencies. @BenHenning and I debugged it and I will write up an issue.
But the tests check that the last node on various blocks and stacks is correct, and that it works with multiple stacks.
Additional information
I moved the existing cursor tests into a subsuite named "movement", which caused indentation changes for a large block of code.