feat: add loopback in cursor navigation, and add tests #8883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
changed the title
rachel-fenichel
requested review from
gonfunko
and removed request for
maribethb
3 tasks
gonfunko
approved these changes
Apr 14, 2025
rachel-fenichel
merged commit fac7504
into
RaspberryPiFoundation:rc/v12.0.0
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Progress on RaspberryPiFoundation/blockly-keyboard-experimentation#409
Proposed Changes
loopparameter togetPreviousNodeandgetNextNodein cursor.Reason for Changes
Both navigation and keyboard drags will use this to smoothly roll from the end of the workspace to the beginning and vice versa, matching standard approaches to searching.
Test Coverage
Added tests in
cursor_test.ts.Documentation
Additional Information
I got some unexpected (to me) behaviour in
getPreviousNodebut they turned out to be unexpected stack nodes. Getting rid of stack nodes is being considered already, and will require updates to these tests.The fourth commit inlines some logic in functions in
line_cursor.ts, but I can revert it if necessary.