Skip to content

Conversation

@BenHenning
Copy link
Collaborator

@BenHenning BenHenning commented Jul 9, 2025

The basics

The details

Resolves

Fixes part of #9221 (or, rather, puts things back into a less broken state)

Proposed Changes

This reverts #9213 and #9216.

Reason for Changes

The "fixed" world is more broken than before, or at least the breakages from before are better understood.

Fundamentally, there are several classes of edge cases for ephemeral focus with widget and drop-down divs that may not have single solutions. A more carefully thought out solution is required at this point, and there isn't sufficient time to safely land such a change ahead of the 12.2 release. It's preferable to revert the attempts at fixing these classes of issues since the previous breakages were harder to hit than the new ones.

#9221 is tracking longer term fixes.

Test Coverage

N/A -- This is a revert.

Documentation

N/A -- This is a revert.

Additional Information

This PR was produced with two git revert commands and has no other changes.

RaspberryPiFoundation/blockly-keyboard-experimentation#563 will need to be reopened after this PR merges since the problems that issue tracked will be reintroduced.

@github-actions github-actions bot added the PR: fix Fixes a bug label Jul 9, 2025
@BenHenning BenHenning marked this pull request as ready for review July 9, 2025 17:28
@BenHenning BenHenning requested a review from a team as a code owner July 9, 2025 17:28
@BenHenning BenHenning requested a review from cpcallen July 9, 2025 17:28
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Jul 9, 2025
@BenHenning BenHenning requested a review from gonfunko July 9, 2025 17:28
@BenHenning BenHenning removed the request for review from cpcallen July 9, 2025 17:28
@BenHenning
Copy link
Collaborator Author

PTAL @gonfunko but also please hold on merging until @microbit-matt-hillsdon has a chance to confirm the revert.

@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Jul 9, 2025
@microbit-matt-hillsdon
Copy link
Collaborator

Looks good, thanks.

I tested MakeCode locally linked to a checkout of this PR and as expected we have RaspberryPiFoundation/blockly-keyboard-experimentation#563 back but the combined widget/dropdown div field editors are working well again for keyboard users.

We also speculatively tested an equivalent pair of git reverts earlier today and all seemed well.

I've also updated our preview deployment of MakeCode to include this PR so you can try it there too (enable Keyboard Controls via settings cog or first tab stop). Simple test program as JavaScript:

input.onButtonPressed(Button.A, function () {
    led.plot(2, 3)
    basic.pause(500)
})

@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Jul 9, 2025
@BenHenning
Copy link
Collaborator Author

Thanks @microbit-matt-hillsdon and @microbit-robert for help with the testing.

Going ahead and merging since this puts Blockly back to an expected good (enough) state for the release.

@BenHenning BenHenning merged commit 5747fee into RaspberryPiFoundation:develop Jul 9, 2025
18 checks passed
@BenHenning BenHenning deleted the revert-drop-down-and-widget-div-prs branch July 9, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants