fix: Revert drop down and widget div PRs #9222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
I@microbit-matt-hillsdon and @microbit-robert validated my changesThe details
Resolves
Fixes part of #9221 (or, rather, puts things back into a less broken state)
Proposed Changes
This reverts #9213 and #9216.
Reason for Changes
The "fixed" world is more broken than before, or at least the breakages from before are better understood.
Fundamentally, there are several classes of edge cases for ephemeral focus with widget and drop-down divs that may not have single solutions. A more carefully thought out solution is required at this point, and there isn't sufficient time to safely land such a change ahead of the 12.2 release. It's preferable to revert the attempts at fixing these classes of issues since the previous breakages were harder to hit than the new ones.
#9221 is tracking longer term fixes.
Test Coverage
N/A -- This is a revert.
Documentation
N/A -- This is a revert.
Additional Information
This PR was produced with two
git revertcommands and has no other changes.RaspberryPiFoundation/blockly-keyboard-experimentation#563 will need to be reopened after this PR merges since the problems that issue tracked will be reintroduced.