Skip to content

fix: enforce placeholder usage for workspace comment #9463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

fix: enforce placeholder usage for workspace comment #9463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b54fdbc
fix: enforce placeholder usage for workspace comment
SimonShiki Nov 11, 2025
1f20dd3
fix: lint
SimonShiki Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/comments/comment_editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import {getFocusManager} from '../focus_manager.js';
import {IFocusableNode} from '../interfaces/i_focusable_node.js';
import {IFocusableTree} from '../interfaces/i_focusable_tree.js';
import {Msg} from '../msg.js';
import * as touch from '../touch.js';
import * as dom from '../utils/dom.js';
import {Rect} from '../utils/rect.js';
Expand Down Expand Up @@ -56,6 +57,7 @@
) as HTMLTextAreaElement;
this.textArea.setAttribute('tabindex', '-1');
this.textArea.setAttribute('dir', this.workspace.RTL ? 'RTL' : 'LTR');
this.textArea.setAttribute('placeholder', Msg['WORKSPACE_COMMENT_DEFAULT_TEXT'])

Check failure on line 60 in core/comments/comment_editor.ts

View workflow job for this annotation

GitHub Actions / lint 

Replace `'placeholder',·Msg['WORKSPACE_COMMENT_DEFAULT_TEXT'])` with `⏎······'placeholder',⏎······Msg['WORKSPACE_COMMENT_DEFAULT_TEXT'],⏎····);`
dom.addClass(this.textArea, 'blocklyCommentText');
dom.addClass(this.textArea, 'blocklyTextarea');
dom.addClass(this.textArea, 'blocklyText');
Expand Down
1 change: 0 additions & 1 deletion core/contextmenu_items.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,6 @@ export function registerCommentCreate() {
if (!workspace) return;
eventUtils.setGroup(true);
const comment = new RenderedWorkspaceComment(workspace);
comment.setPlaceholderText(Msg['WORKSPACE_COMMENT_DEFAULT_TEXT']);
comment.moveTo(
svgMath.screenToWsCoordinates(
workspace,
Expand Down
Loading