feat: Add verbosity shortcuts (experimental) #9481
Conversation
This also fills in more field labels (particularly for options) and adds example 'where am I?' shortcuts for team testing.
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Quick self-review spot check.
github-actions
bot
added
PR: feature
…ity-shortcuts Conflicts: core/block_svg.ts
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Post-conflict merge spot check.
github-actions
bot
added
PR: feature
|
PTAL @maribethb. I'm not considering this a full completion of RaspberryPiFoundation/blockly-keyboard-experimentation#764 for the caveats listed in the PR description, but it seems perhaps reasonable to check this in as-is and iterate to address the remaining needs of the issue (which may require changes both here & in the plugin). Note I'll also revisit #9470 after this is merged since that's lower priority (and duplicates some of the code here so it's easier to pipeline it). At least 2 of the 4 WebdriverIO failures on Mac seem to be existing. The other 2 look a bit different, but I don't think this is actually a new failure since the Linux tests aren't failing (and I'd expect them to in such a case). |
|
/cc @microbit-robert for FYI. |
core/shortcut_items.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Registeres a keyboard shortcut for re-reading the current selected block's |
| !workspace.isDragging() && | ||
| !getFocusManager().ephemeralFocusTaken() && | ||
| !!getFocusManager().getFocusedNode() && | ||
| getFocusManager().getFocusedNode() instanceof BlockSvg |
There was a problem hiding this comment.
This shortcut should work for fields, connections, and icons too. The idea is that you can get information about the block without having to change your focus. This can help you figure out what to type into a field, for example.
I know you have a lot in flight right now though so it may make more sense to come back to this as a follow up (or pass to Aaron) in order to at least get the base version submitted.
There was a problem hiding this comment.
Yep I agree, and that's part of why this isn't fully resolving RaspberryPiFoundation/blockly-keyboard-experimentation#764. I'll reference this comment there so that this context isn't lost, and I'm happy for @gonfunko to take over that issue if he has bandwidth to continue chipping away at the other parts of it.
…ity-shortcuts Conflicts: core/block_svg.ts
This fixes the build being broken.
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Spot checked changes.
|
Failures are unrelated. Since there's more open work to do I won't be addressing your second comment @maribethb but I did note it in the main tracking issue for the shortcut so that it gets addressed. I'm hoping merging this earlier will allow it to potentially be tested in interim (or, at least, available for testing). |
BenHenning
merged commit 80660bd
into
RaspberryPiFoundation:add-screen-reader-support-experimental
2 participants
The basics
The details
Resolves
Fixes part of RaspberryPiFoundation/blockly-keyboard-experimentation#764
Fixes part of #9450 (infrastructure needs)
Proposed Changes
Introduces support for two new "where am I?" shortcuts for helping to provide location context for users:
I: re-reads the current selected block with full verbosity (i.e. also includes the block's field types with their values in the readout).shift+I: reads the current selected block's parent with full verbosity.Note that this includes some functional changes to
Fieldto allow for more powerful customization of a field's ARIA representation (by splitting up value and type), though a field's value defaults potentially to null which will be ignored in the final ARIA computed label. This seems necessary per the discussion here: https://github.com/RaspberryPiFoundation/blockly/pull/9470/files#r2541508565 but more consideration may be needed here as part of #9307.Some limitations in the new shortcuts:
Reason for Changes
RaspberryPiFoundation/blockly-keyboard-experimentation#764 provides context on the specific needs addressed here.
Test Coverage
Self tested. No new automated tests needed for experimental work.
Documentation
No new documentation needed for experimental work.
Additional Information
This was spun out of #9470 with the intent of getting shortcuts initially working checked in even if the entirety of the experience is incomplete.