Extend job nodes + job editing flow, fix job cost calculation, edit job draft + small fixes #10
Conversation
…. JobEditFormWrapper initial refactoring to add all steps
Job editing flow, job page UX, extend job nodes + scale up job workers calls
commit 64095dd Author: wzrdx <[email protected]> Date: Tue Oct 14 15:14:53 2025 +0300 feat: Implement edit job draft flow commit 04ed7fb Author: wzrdx <[email protected]> Date: Tue Oct 14 14:14:30 2025 +0300 fix: JobDraftBreadcrumbs navigation commit 10d43b7 Author: wzrdx <[email protected]> Date: Tue Oct 14 14:09:40 2025 +0300 feat: Create EditJobDraft and JobDraftBreadcrumbs commit 38a3af9 Author: wzrdx <[email protected]> Date: Tue Oct 14 13:22:30 2025 +0300 chore: Modify isUsingDevAddress in config, Create DraftEditFormWrapper
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| const signAndBuildScaleUpWorkersRequest = async ( | ||
| job: RunningJobWithResources, | ||
| targetNodes: string[], | ||
| containerType: ContainerOrWorkerType, | ||
| ) => { | ||
| const nonce = generateDeeployNonce(); | ||
|
|
||
| const payloadWithIdentifiers = { | ||
| job_id: Number(job.id), | ||
| app_id: job.alias, | ||
| target_nodes: targetNodes, | ||
| target_nodes_count: 0, | ||
| app_params: { | ||
| CONTAINER_RESOURCES: formatContainerResources(containerType), | ||
| }, | ||
| project_id: job.projectHash, |
There was a problem hiding this comment.
The payload signed in signAndBuildScaleUpWorkersRequest never populates the fields that /scale_up_job_workers expects. The request schema requires both a non‑zero target_nodes_count and a node_res_req string (see the type definition in src/lib/api/deeploy.ts), but the builder hardcodes target_nodes_count: 0 and sends the resources under app_params instead. When a user increases the target node count, the backend will receive a request that asks for zero additional workers and lacks the resource requirements field, so the scale‑up call will fail regardless of the form inputs. Populate target_nodes_count with the additional nodes and send the resources in node_res_req.
Useful? React with 👍 / 👎.
No description provided.