Conversation
…stomParametersSection (inital implementation)
Implement JsonEditor and CustomParamsSection for native jobs
commit 9e1418c Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 13:52:48 2025 +0300 feat: Format ports from array in deeploy utils commit e9da986 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 12:55:33 2025 +0300 chore: Update schema to use array, refactor PortMappingSection to use fields commit 71c02de Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 12:36:08 2025 +0300 refactor: Move ports schema to genericAppDeploymentSchema and separate PortMappingSection from AppParametersSection
commit ef6ddf7 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 16:03:29 2025 +0300 fix: Refactor service tag so it's serializable commit 38b2723 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 15:56:15 2025 +0300 fix: GpuType schema bug commit f437d25 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 15:37:14 2025 +0300 fix: Allow editing the allowReplicationInTheWild field of a job commit 6a18a0f Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 15:26:05 2025 +0300 fix: Edit job failing for native jobs with chainstore response = false
commit 8deb8b9 Merge: f7b1540 d71d504 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Wed Oct 22 10:21:23 2025 +0300 Merge branch 'develop' into edit-secondary-plugins commit f7b1540 Merge: 43b599a 0625859 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Tue Oct 21 14:56:46 2025 +0300 Merge branch 'develop' into edit-secondary-plugins commit 43b599a Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Mon Oct 20 13:43:15 2025 +0300 chore: Display an error message when missing .env variables
Job/job draft/native job secondary plugins editing
* refactor: Secondary plugins into plugins * refactor: DeploymentType to use 'pluginType' for CAR/WAR * feat: Display Custom Parameters in JobConfigurations + small UX fixes * refactor: Split JobConfigurations into two seperate sections: deployment & plugins * feat: Display Pipeline section in JobDeploymentSection * feat: Enable updating custom params for * chore: Add a warning for when chainstoreResponse is set to true * fix: Update pipeline input type and URI in JobEditFormWrapper, fix chainstoreResponse in deeploy-utils * feat: Create job using plugins array initial implementation * fix: Native schema and NativeJobsCostRundown * fix: Schema fixes for plugins * feat: Edit running job plugins * style: Target nodes section restyling * fix: Possible undefined values when using JobKeyValueSection
* feat: Create VariableSectionControls and implement in the first components * style: Generic job adding flow * style: Use VariableSectionControls in CustomParametersSection * chore: Remove unnecessary interaction context usage * refactor: Plugins step initial implementation * fix: Native job adding flow * fix: Draft job editing for native jobs * feat: Customize the AddJobCard to be used in the Plugins step * refactor: PluginsSection to use cards * fix: PluginEnvVariablesSection * feat: Clear root error when adding a new plugin + fix WAR plugin colors * refactor: Replace BorderedCard with SlateCard in ReviewAndConfirm component * feat: Running native job Plugins step initial implementation * chore: Display changes to the Plugins step in ReviewAndConfirm, scroll to top on each job step * fix: SlateCard not rendering its props, scroll to a newly added plugin in PluginsSection * fix: Job hiding updatingServerAliases * fix: Default value for maxEntries in KeyValueEntriesSection
* feat: Display and edit pipeline params * chore: Disable Application Type as it is not used at the moment
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the plugin/deployment type system for Native jobs, introducing a more structured approach to managing plugins. Key changes include renaming deployment-related types, consolidating plugin management, and adding new UI components for better user experience.
- Restructures the type system from "secondary plugins" to "plugins" with new
BasePluginTypeandPluginTypeenums - Consolidates port mapping from deployment types into a dedicated array structure
- Adds new UI components including
JsonEditor, custom parameters section, and improved form controls - Introduces public profile management functionality
Reviewed Changes
Copilot reviewed 104 out of 108 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/typedefs/steps/deploymentStepTypes.ts | Refactored type definitions: renamed SecondaryPlugin to Plugin, replaced type with pluginType, added PortMappingEntry type |
| src/shared/PortMappingSection.tsx | Completely rewritten to use field arrays instead of Record for port mappings |
| src/shared/jobs/native/CustomParametersSection.tsx | New component for managing custom parameters with JSON/string toggle support |
| src/schemas/steps/deployment.ts | Updated validation schemas to match new type structure and field names |
| src/lib/deeploy-utils.ts | Updated formatting functions to handle new plugin structure and port mapping arrays |
| src/components/create-job/plugins/* | New plugin management components replacing secondary-plugins |
| src/components/account/profile/* | New profile management components for public profile editing |
| src/shared/JsonEditor.tsx | New JSON editor component using CodeMirror |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/shared/PortMappingSection.tsx
Outdated
|
|
||
| <VariableSectionControls | ||
| displayLabel="port mappings" | ||
| onClick={() => append({ key: '', value: '' })} |
There was a problem hiding this comment.
The append function is called with { key: '', value: '' } but should use { hostPort: undefined, containerPort: undefined } to match the PortMappingEntry interface which expects hostPort: number and containerPort: number properties, not key and value.
src/components/create-job/steps/deployment/NativeDeployment.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.