Skip to content

Skip one more test on macOS #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Skip one more test on macOS #1324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
407fd40
Skip one more test on macOS
eddelbuettel Aug 20, 2024
fdf6385
Add macOS-only CI runner
eddelbuettel Aug 20, 2024
d1f431b
Adjust name to 'macos'
eddelbuettel Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2024-08-20 Dirk Eddelbuettel <[email protected]>

* inst/tinytest/test_sugar.R: Skip one more NA related test on arm64
and macOS as failure is seen at r-universe on arm64

2024-08-19 Dirk Eddelbuettel <[email protected]>

* Contributing.md: Refreshed content
Expand Down
2 changes: 1 addition & 1 deletion inst/tinytest/test_sugar.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,7 +1567,7 @@ expect_error(strimws(x[1], "invalid"), info = "strimws -- bad `which` argument")
## min/max
# test.sugar.min.max <- function() {
## min(empty) gives NA for integer, Inf for numeric (#844)
expect_true(is.na(intmin(integer(0))), "min(integer(0))")
if (!isArmMacOs) expect_true(is.na(intmin(integer(0))), "min(integer(0))")
if (!isArmMacOs) expect_equal(doublemin(numeric(0)), Inf, info = "min(numeric(0))")

## max(empty_ gives NA for integer, Inf for numeric (#844)
Expand Down
Loading