more vestiges

Author: MichaelChirico

R/data.table.R

@@ -2919,10 +2919,10 @@ setDT = function(x, keep.rownames=FALSE, key=NULL, check.names=FALSE) {
     # check no matrix-like columns, #3760. Allow a single list(matrix) is unambiguous and depended on by some revdeps, #3581
     # for performance, only warn on the first such column, #5426
     for (jj in seq_along(x)) {
-      if (test_posixl_column && inherits(x[[jj]], "POSIXlt")) {
+      if (inherits(x[[jj]], "POSIXlt")) {
         .Call(Cerr_posixl_column_r, jj)
       }
-      if (test_matrix_column && length(dim(x[[jj]])) > 1L) {
+      if (length(dim(x[[jj]])) > 1L) {
         .Call(Cwarn_matrix_column_r, jj)
         break
       }

src/assign.c

@@ -220,9 +220,8 @@ SEXP setdt_nrows(SEXP x)
      *   e.g. in package eplusr which calls setDT on a list when parsing JSON. Operations which
      *   fail for NULL columns will give helpful error at that point, #3480 and #3471 */
     if (Rf_isNull(xi)) continue;
-    if (test_posixl_cols && Rf_inherits(xi, "POSIXlt")) {
-      warn_posixl_column(i+1);
-      test_posixl_cols = false;
+    if (Rf_inherits(xi, "POSIXlt")) {
+      err_posixl_column(i+1);
     }
     SEXP dim_xi = getAttrib(xi, R_DimSymbol);
     R_len_t len_xi;