no need so many vars

jangorecki · jangorecki · commit 3003c224ab13 · 2025-09-14T22:37:10.000+02:00
diff --git a/R/frollapply.R b/R/frollapply.R
@@ -36,12 +36,9 @@ simplifylist = function(x, fill, ansmask) {
       }
     }
   }
-  all.t = vapply_1c(x, typeof, use.names=FALSE)
-  all.ut = unique(all.t)
-  l = lengths(x)
-  ul = unique(l)
+  all.ut = unique(vapply_1c(x, typeof, use.names=FALSE))
   if ((length(all.ut) == 1L) && all(all.ut %in% c("integer","logical","double","complex","character","raw"))) {
-    if (identical(ul, 1L)) { ## length 1
+    if (identical(unique(lengths(x)), 1L)) { ## length 1
       return(unlist(x, recursive=FALSE, use.names=FALSE))
     } else if (equal.lengths(x)) { ## length 2+ and equal
       return(rbindlist(lapply(x, as.list)))

Original file line number	Diff line number	Diff line change
`@@ -36,12 +36,9 @@ simplifylist = function(x, fill, ansmask) {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`}`
`39`		`- all.t = vapply_1c(x, typeof, use.names=FALSE)`
`40`		`- all.ut = unique(all.t)`
`41`		`- l = lengths(x)`
`42`		`- ul = unique(l)`
	`39`	`+ all.ut = unique(vapply_1c(x, typeof, use.names=FALSE))`
`43`	`40`	`if ((length(all.ut) == 1L) && all(all.ut %in% c("integer","logical","double","complex","character","raw"))) {`
`44`		`- if (identical(ul, 1L)) { ## length 1`
	`41`	`+ if (identical(unique(lengths(x)), 1L)) { ## length 1`
`45`	`42`	`return(unlist(x, recursive=FALSE, use.names=FALSE))`
`46`	`43`	`} else if (equal.lengths(x)) { ## length 2+ and equal`
`47`	`44`	`return(rbindlist(lapply(x, as.list)))`