..

Author: venom1204

.ci/atime/tests.R

@@ -286,22 +286,24 @@ test.list <- atime::atime_test_list(
     Slow = "548410d23dd74b625e8ea9aeb1a5d2e9dddd2927",   # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/548410d23dd74b625e8ea9aeb1a5d2e9dddd2927)
     Fast = "c0b32a60466bed0e63420ec105bc75c34590865e"),  # Commit in the PR (https://github.com/Rdatatable/data.table/pull/7144/commits) that uses a much faster implementation
 
-  "tables() non-recursive performance in #2606" = atime::atime_test(
+  "tables() !recursive refactor in #2606" = atime::atime_test(
     N = as.integer(10^seq(1, 4, by = 0.5)),
     setup = {
-      for (i in 1:N) {
-        assign(paste0("DT_perf_test_", i), data.table(a = 1))
-      }
+      test_env <- new.env()
+      local({
+        for (i in 1:N) {
+          assign(paste0("dt_perf_test", i), data.table(a=1), envir = test_env)
+          assign(paste0("vec_perf_test", i), 1, envir = test_env)
+        }
+      })
+      test_env
     },
     expr = {
-      if ("recursive" %in% names(formals(data.table::tables))) {
-        data.table::tables(silent = TRUE, recursive = FALSE)
-      } else {
-        data.table::tables(silent = TRUE)
-      }
+      library(data.table)
+      data.table::tables(env = test_env, silent = TRUE, index = TRUE);
+      NULL
     },
     before = "7c59daaed1836db57747d92494b1ce96612bbf80",   # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/7c59daaed1836db57747d92494b1ce96612bbf80)
     after = "6fee38c89200e10dcc10a6f2057ab784f9a011e7"),  # Commit in the PR (https://github.com/Rdatatable/data.table/pull/7141/commits)
-    
     tests=extra.test.list)
 # nolint end: undesirable_operator_linter.