Skip to content

Conversation

@MichaelChirico
Copy link
Member

Closes #5442. Not sure it warrants a NEWS item; excluded for now.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (a6009e8) to head (44377a0).
Report is 1029 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5443      +/-   ##
==========================================
- Coverage   97.46%   97.46%   -0.01%     
==========================================
  Files          80       80              
  Lines       14822    14820       -2     
==========================================
- Hits        14447    14445       -2     
  Misses        375      375              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico
Copy link
Member Author

@tdhock WDYT, worthy of a NEWS item?

@jangorecki
Copy link
Member

I would rebase that on top of mergelist or forderLazy branch. This branching is very complex and I was just recently resolving conflicts to latest master there.

@MichaelChirico
Copy link
Member Author

MichaelChirico commented Dec 14, 2023

OK, marking as draft for now, pending #4370 (specifically, the #6437 chunk) or #4386

@MichaelChirico MichaelChirico marked this pull request as draft December 14, 2023 11:38
@tdhock
Copy link
Member

tdhock commented Dec 14, 2023

I don't really understand what this part of the code is doing, but if there are no user facing changes I would think NEWS item is not necessary.

@MichaelChirico
Copy link
Member Author

no user facing changes

Somewhat ambiguous -- it's an error message, so it will indeed face some users. Anyway let's wait till unmarked draft to discuss further.

@MichaelChirico
Copy link
Member Author

I would rebase that on top of mergelist or forderLazy branch. This branching is very complex and I was just recently resolving conflicts to latest master there.

Indeed #4370 makes this totally obsolete, already in master from cf7fb11 (#6436)

@MichaelChirico MichaelChirico deleted the MichaelChirico-patch-5 branch July 3, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stack trace for allow.cartesian error is ugly

3 participants