Russian translation

[aitap]

First of all, big thanks to @Meeko28 and @Kate-lz! This would have never been possible without your work. I hope that you've received your grant payouts, or at least that the paperwork is on the way.

The *.po files are prepared against the current *.pot files, so a few of the strings containing fragmented sentences have been left untranslated.

Questions:

• Should this pull request be WIP until all the *.pot files are updated? I've got to submit some edits for the R message templates too, and the vignettes and the help pages may need their own rounds of editing too.
• Where do I put the data.table.ru package with the three vignettes (intro, reshape, importing) and (currently) 25% of the help pages translated? I ended up using a po4a-based workflow for the vignettes (thank you very much @phgrosjean for the hint) and a similar but more handmade workflow for the help files. The resulting package (when built) depends on only data.table and suggests a few of its dependencies (to build vignettes and run examples).

[Meeko28]

Hi this is Nichole Haines. I didn't get a grant pay out yet.

…

On Sat, Sep 21, 2024, 8:15 AM aitap ***@***.***> wrote: First of all, big thanks to @Meeko28 <https://github.com/Meeko28> and @Kate-lz <https://github.com/Kate-lz>! This would have never been possible without your work. I hope that you've received your grant payouts, or at least that the paperwork is on the way. The *.po files are prepared against the current *.pot files, so a few of the strings containing fragmented sentences have been left untranslated. Questions: - Should this pull request be WIP until all the *.pot files are updated? I've got to submit some edits for the R message templates too, and the vignettes and the help pages may need their own rounds of editing too. - Where do I put the data.table.ru package <https://codeberg.org/aitap/data.table.ru/src/branch/translated-package> with the three vignettes (intro, reshape, importing) and (currently) 25% of the help pages translated? I ended up using a po4a <https://po4a.org/>-based workflow for the vignettes (thank you very much @phgrosjean <https://github.com/phgrosjean> for the hint) and a similar but more handmade workflow <https://codeberg.org/aitap/Rd2gettext> for the help files. The resulting package (when built) depends on only data.table and suggests a few of its dependencies (to build vignettes and run examples). ------------------------------ You can view, comment on, or merge this pull request online at: #6516 Commit Summary - 2d8565c <2d8565c> Import Russian translations - 999d316 <999d316> Generate Russian *.mo files File Changes (4 files <https://github.com/Rdatatable/data.table/pull/6516/files>) - *A* inst/po/ru/LC_MESSAGES/R-data.table.mo <https://github.com/Rdatatable/data.table/pull/6516/files#diff-98af78fcf8f059ad7d54afdf3181545fb8bd4e50d1bf78bedd41fb7c19e871cd> (0) - *A* inst/po/ru/LC_MESSAGES/data.table.mo <https://github.com/Rdatatable/data.table/pull/6516/files#diff-a7d2a75665321ab130c6911f06829df2471ec6d94b049ac77704c09db45750b8> (0) - *A* po/R-ru.po <https://github.com/Rdatatable/data.table/pull/6516/files#diff-364263e332536dc6ed6cb516aad03be63ebac11544c3bc0f9d2c4172f8089dd7> (3415) - *A* po/ru.po <https://github.com/Rdatatable/data.table/pull/6516/files#diff-92817e54c697fd6395db7e9eca8f2468538e83db228823136eaa96d834d74f76> (4545) Patch Links: - https://github.com/Rdatatable/data.table/pull/6516.patch - https://github.com/Rdatatable/data.table/pull/6516.diff — Reply to this email directly, view it on GitHub <#6516>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BKTIDASJDBTTB5VVTEDGIQTZXVPP5AVCNFSM6AAAAABOTRHZJKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DAMRSGA2DAMA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MichaelChirico]

Should this pull request be WIP until all the *.pot files are updated?

Yea, given our normal workflow is to update .pot near release time, I think it's not ideal to trigger the update now... if it's not too much trouble, we could "left join" the the current .pot to your translations as a PR to merge now, then leave this one pending until the .pot is updated (which will probably end up invalidating some translations here).

[aitap]

we could "left join" the the current .pot to your translations as a PR to merge now

Let's try this. I've ran msgmerge -U on both files, so the new translations we had prepared with a manually generated data.table.pot should be commented out, ready for reuse.

[aitap]

Should I be preparing a new pull request? I think the current branch will msgmerge cleanly against the current *.pot.files.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (32dfd8d) to head (9ccfdcd).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6516   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          79       79           
  Lines       14642    14642           
=======================================
  Hits        14438    14438           
  Misses        204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MichaelChirico]

Sorry @aitap, haven't had time to look closely. Will report back soon :)

[MichaelChirico]

A new .pot will be generated shortly -- do you want to merge this as-is and start a second PR once that's done, or is it easier to have only one PR? I'm OK either way @aitap

[aitap]

Let me update this one.

[aitap]

I think it's done. The individual commits can be omitted or split off if needed.

[MichaelChirico]

Excellent, thanks!!