Skip to content

Conversation

@jmrung
Copy link
Contributor

@jmrung jmrung commented Sep 21, 2024

I am providing both an .svg and a high resolution .png of translation team-specific data.table logos. The differences between the main logo and translation team-specific logos are the inclusion of a two- to four-letter language code as superscripted text at the end of the package name within the logo. Full code list and additional information on codes here. I used lowercase letters since this seems most common with these codes.

I am not sure if more specific country-based versions of the language codes are needed for any of the teams (the four-letter versions of the codes, see list here). I've made one for the Brazilian team, based on recent discussions (the "pt-br" superscript), which provides a nice example of what this would look like.

Please let me know if any general changes are needed and if additional, country-specific language code versions would better serve any of the teams.

Related to #6222

This upload provides both an .svg and a high resolution .png of translation team-specific data.table logos. The differences between the main logo and translation team-specific logos are the inclusion of a two- to four-letter language code as superscripted text at the end of the package name within the logo.  [Full code list here](https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes). I used lowercase letters since this seems most common with these codes.

I am not sure if more specific country-based versions of the language codes are needed for any of the teams (the four-letter versions of the codes, [see list here](https://www.andiamo.co.uk/resources/iso-language-codes/)). I've made one for the Brazilian team, based on recent discussions (file name ending with "ptbr"), which provides a nice example of what this would look like.

Please let me know if any general changes are needed and if additional, country-specific language code versions would better serve any of the teams.
@jmrung jmrung added the translation issues/PRs related to message translation projects label Sep 21, 2024
@aitap
Copy link
Member

aitap commented Sep 22, 2024

Do you think the logos could benefit from making the language code larger? I've tried on the avatar of the Brazilian Portuguese team by pasting the image URL into the Web developer toolbar, and the language code is just 9 pixels tall (on my relatively high-res old ThinkPad).

@MichaelChirico MichaelChirico requested review from tdhock and removed request for MichaelChirico September 23, 2024 03:09
@MichaelChirico
Copy link
Member

I think @tdhock is most familiar with the discussion here. At a glance I wonder if the code would fit better centered underneath 'data.table' rather than superscripted next to it. Maybe a slight design difference could help distinguish it, e.g. italics or a slightly different font or color. Just a thought.

@ben-schwen
Copy link
Member

Isn't there a mismatch between the .png and .svg for FR?

CODEOWNERS Outdated
/man/openmp-utils.Rd @Anirban166

# meta
/.graphics/translation-team-logos/*.png @tdhock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmrung could you please volunteer as reviewer under .graphics, since you created the new logos?

Text was not converted to path and not appropriately showing up in browser
@jmrung
Copy link
Contributor Author

jmrung commented Sep 23, 2024

Isn't there a mismatch between the .png and .svg for FR?

Good catch @ben-schwen! I missed changing the text for the language code to a path, which was causing the problem. This is fixed now in a recent commit.

@aitap & @MichaelChirico Thank you for the suggestions! I'll play around with a few possibilities to help with the readability of the language codes and post again soon to get everyone's thoughts. Moving the language code outside of the hex might be the most effective since the space inside is pretty tight.

@MichaelChirico
Copy link
Member

Hi @jmrung any update here? Thanks for your time!

tdhock requested that I take over as reviewer. Making this change
@jmrung
Copy link
Contributor Author

jmrung commented Jan 25, 2025

Hey @MichaelChirico, yes!

How does everyone feel about this style? (full size)
datatable-pt_v2

And the approximate size as it would appear on translation team pages
datatable-pt2_resize

I can fiddle with the line properties a bit on the seal if needed so it stays crisper when downsizing, though the resized version shown here was scaled after saving to png (so may be an artifact of that).

@aitap
Copy link
Member

aitap commented Jan 26, 2025

It's hard to make the logo recognisable in all cases. Consider the reviewers pane for #6767 with the Brazilian Portuguese logo added manually:
reviewers

For maximum legibility, I'd go with a large language code in data.table colours, something like this:
reviewers2

But I'm not a designer and this is still far from pretty. The current Brazilian logo is still more legible.

Maybe uniformity is good. Perhaps it's more important to see that the pending reviewer is a data.table team than to see which team it is.

@tdhock
Copy link
Member

tdhock commented Jan 26, 2025

I like the idea of using the two letter language codes. that would fix the issue one person had with the flags (countries != languages)

@MichaelChirico MichaelChirico requested a review from tdhock January 27, 2025 18:48
@MichaelChirico
Copy link
Member

I like Ivan's suggestion. Obviously the data.table logo is mostly obscured, but that's not what's important in this case -- the language code is. We can still basically infer what's behind the letters.

Is it possible we'll ever put the regional codes on a separate team (e.g. @Rdatatable/portugese-brazilian vs @Rdatatable/portugese-portugal)? I would guess no, in which case we don't need to think about how it'd look with 5 characters.

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (2714cb4) to head (3448b35).
Report is 304 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6519      +/-   ##
==========================================
+ Coverage   98.62%   98.69%   +0.07%     
==========================================
  Files          79       79              
  Lines       14640    14689      +49     
==========================================
+ Hits        14438    14498      +60     
+ Misses        202      191      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmrung
Copy link
Contributor Author

jmrung commented Jan 28, 2025

Great context on the use and suggestion, @aitap. Thank you!

Full, ~120px square, and ~20px square:

datatable-pt_full_ns
datatable-pt_120sq_ns
datatable-ptbr_20sq_ns

The text can be increased a bit still if the readability leaves a bit to be desired at ~20px, though it seems okay at the current size (at least to me--other eyes needed!). I left a little breathing room for balance with seal visibility at the larger dimensions, for now.

@MichaelChirico
Copy link
Member

Hey @jmrung I think we are in agreement about the latest version. I think you just need to upload them into this branch, right?

@jmrung
Copy link
Contributor Author

jmrung commented Jun 28, 2025 via email

@jmrung
Copy link
Contributor Author

jmrung commented Jun 29, 2025

@MichaelChirico, I all the new ones are uploaded. 😊 I put them in a separate directory (translation-team-codelogos) so that the package logo look-a-likes are still retained in case something that has both the package name and the language reference is helpful.

If ultimately not needed, they can be deleted of course! New versions below, shown at ~200x200 and ~20x20

@MichaelChirico MichaelChirico requested a review from aitap June 29, 2025 20:41
@MichaelChirico
Copy link
Member

Looks fine to me, awesome!

@tdhock could you weigh in on the file structure?

What is the procedure for adding new languages in the future?

Copy link
Member

@aitap aitap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very readable, thank you!

@MichaelChirico
Copy link
Member

MichaelChirico commented Jul 2, 2025

I'll go ahead and merge, we can refine later if needed. Thank you!!!

@MichaelChirico MichaelChirico merged commit 5b1c443 into master Jul 2, 2025
11 checks passed
@MichaelChirico MichaelChirico deleted the translation-team-logos branch July 2, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation issues/PRs related to message translation projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants