-
Notifications
You must be signed in to change notification settings - Fork 1k
Adding translation team logos #6519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This upload provides both an .svg and a high resolution .png of translation team-specific data.table logos. The differences between the main logo and translation team-specific logos are the inclusion of a two- to four-letter language code as superscripted text at the end of the package name within the logo. [Full code list here](https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes). I used lowercase letters since this seems most common with these codes. I am not sure if more specific country-based versions of the language codes are needed for any of the teams (the four-letter versions of the codes, [see list here](https://www.andiamo.co.uk/resources/iso-language-codes/)). I've made one for the Brazilian team, based on recent discussions (file name ending with "ptbr"), which provides a nice example of what this would look like. Please let me know if any general changes are needed and if additional, country-specific language code versions would better serve any of the teams.
|
Do you think the logos could benefit from making the language code larger? I've tried on the avatar of the Brazilian Portuguese team by pasting the image URL into the Web developer toolbar, and the language code is just 9 pixels tall (on my relatively high-res old ThinkPad). |
|
I think @tdhock is most familiar with the discussion here. At a glance I wonder if the code would fit better centered underneath 'data.table' rather than superscripted next to it. Maybe a slight design difference could help distinguish it, e.g. italics or a slightly different font or color. Just a thought. |
|
Isn't there a mismatch between the .png and .svg for FR? |
CODEOWNERS
Outdated
| /man/openmp-utils.Rd @Anirban166 | ||
|
|
||
| # meta | ||
| /.graphics/translation-team-logos/*.png @tdhock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmrung could you please volunteer as reviewer under .graphics, since you created the new logos?
Text was not converted to path and not appropriately showing up in browser
Good catch @ben-schwen! I missed changing the text for the language code to a path, which was causing the problem. This is fixed now in a recent commit. @aitap & @MichaelChirico Thank you for the suggestions! I'll play around with a few possibilities to help with the readability of the language codes and post again soon to get everyone's thoughts. Moving the language code outside of the hex might be the most effective since the space inside is pretty tight. |
|
Hi @jmrung any update here? Thanks for your time! |
tdhock requested that I take over as reviewer. Making this change
|
Hey @MichaelChirico, yes! How does everyone feel about this style? (full size) And the approximate size as it would appear on translation team pages I can fiddle with the line properties a bit on the seal if needed so it stays crisper when downsizing, though the resized version shown here was scaled after saving to png (so may be an artifact of that). |
|
It's hard to make the logo recognisable in all cases. Consider the reviewers pane for #6767 with the Brazilian Portuguese logo added manually: For maximum legibility, I'd go with a large language code in But I'm not a designer and this is still far from pretty. The current Brazilian logo is still more legible. Maybe uniformity is good. Perhaps it's more important to see that the pending reviewer is a |
|
I like the idea of using the two letter language codes. that would fix the issue one person had with the flags (countries != languages) |
|
I like Ivan's suggestion. Obviously the data.table logo is mostly obscured, but that's not what's important in this case -- the language code is. We can still basically infer what's behind the letters. Is it possible we'll ever put the regional codes on a separate team (e.g. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6519 +/- ##
==========================================
+ Coverage 98.62% 98.69% +0.07%
==========================================
Files 79 79
Lines 14640 14689 +49
==========================================
+ Hits 14438 14498 +60
+ Misses 202 191 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great context on the use and suggestion, @aitap. Thank you! Full, ~120px square, and ~20px square: The text can be increased a bit still if the readability leaves a bit to be desired at ~20px, though it seems okay at the current size (at least to me--other eyes needed!). I left a little breathing room for balance with seal visibility at the larger dimensions, for now. |
|
Hey @jmrung I think we are in agreement about the latest version. I think you just need to upload them into this branch, right? |
|
Ah! I had been waiting on a verbal confirmation before making all the individual versions, but in hindsight realize I also didn’t state that. Apologies! I will prep and export the remaining and upload soon. I will try to get that done this weekend. Best,Jill
|
Creating new directory for language code-forward logos
Bogus file to make a directory, getting rid of
Including (simple) .svg and .png
Deleting since only the two-letter codes will be used
Fixed some height variation across the logos where possible
|
@MichaelChirico, I all the new ones are uploaded. 😊 I put them in a separate directory (translation-team-codelogos) so that the package logo look-a-likes are still retained in case something that has both the package name and the language reference is helpful. If ultimately not needed, they can be deleted of course! New versions below, shown at ~200x200 and ~20x20 |
|
Looks fine to me, awesome! @tdhock could you weigh in on the file structure? What is the procedure for adding new languages in the future? |
aitap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's very readable, thank you!
|
I'll go ahead and merge, we can refine later if needed. Thank you!!! |







I am providing both an .svg and a high resolution .png of translation team-specific data.table logos. The differences between the main logo and translation team-specific logos are the inclusion of a two- to four-letter language code as superscripted text at the end of the package name within the logo. Full code list and additional information on codes here. I used lowercase letters since this seems most common with these codes.
I am not sure if more specific country-based versions of the language codes are needed for any of the teams (the four-letter versions of the codes, see list here). I've made one for the Brazilian team, based on recent discussions (the "pt-br" superscript), which provides a nice example of what this would look like.
Please let me know if any general changes are needed and if additional, country-specific language code versions would better serve any of the teams.
Related to #6222