Skip to content

Progress deprecated option 'datatable.nomatch' to error #6644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-schwen merged 3 commits into from
Mar 12, 2025
Merged

Progress deprecated option 'datatable.nomatch' to error #6644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd39ed4
Progress deprecated option to error
MichaelChirico Dec 10, 2024
cd7b5a1
NEWS
MichaelChirico Feb 25, 2025
edc8695
Merge branch 'master' into nomatch-option-error
MichaelChirico Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
+ Argument `logicalAsInt` to `fwrite()` has been removed.
+ Argument `autostart` to `fread()` has been removed.
+ Argument `in.place` to `droplevels` has been removed.
+ It's now an error to set `datatable.nomatch`, which has been warning since 1.15.0.

# data.table [v1.17.0](https://github.com/Rdatatable/data.table/milestone/34) (20 Feb 2025)

Expand Down
11 changes: 2 additions & 9 deletions R/onLoad.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,8 @@
# nocov start

.pkg.store = new.env()
.pkg.store$.unsafe.done = FALSE
.unsafe.opt = function() {
if (.pkg.store$.unsafe.done) return(invisible())
val = getOption("datatable.nomatch")
if (is.null(val)) return(invisible()) # not defined (it hasn't been defined in .onLoad since v1.12.4)
warningf("Option 'datatable.nomatch' is defined but is now ignored. Please see note 11 in v1.12.4 NEWS (Oct 2019), and note 14 in v1.14.2.")
# leave this as warning for a long time
.pkg.store$.unsafe.done = TRUE
invisible()
if (!is.null(getOption("datatable.nomatch")))
stopf("Option 'datatable.nomatch' is defined but is now ignored. Please see note 11 in v1.12.4 NEWS (Oct 2019), and note 14 in v1.14.2.")
}

.Last.updated = vector("integer", 1L) # exported variable; number of rows updated by the last := or set(), #1885
Expand Down
Loading