Skip to content

Progress deprecation of with=FALSE + :=#6648

Merged
ben-schwen merged 5 commits intomasterfrom
deprec-with-set
Jan 21, 2025
Merged

Progress deprecation of with=FALSE + :=#6648
ben-schwen merged 5 commits intomasterfrom
deprec-with-set

Conversation

@MichaelChirico
Copy link
Member

No description provided.

@MichaelChirico MichaelChirico added this to the 1.17.0 milestone Dec 10, 2024
@github-actions
Copy link

github-actions bot commented Dec 10, 2024

Comparison Plot

Generated via commit 4902ace

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 41 seconds
Installing different package versions 7 minutes and 37 seconds
Running and plotting the test cases 2 minutes and 17 seconds

@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (d263924) to head (31d8301).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6648      +/-   ##
==========================================
- Coverage   98.62%   98.62%   -0.01%     
==========================================
  Files          79       79              
  Lines       14630    14626       -4     
==========================================
- Hits        14429    14425       -4     
  Misses        201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member Author

Pinging @ben-schwen :)

@ben-schwen
Copy link
Member

LGTM TY!

@ben-schwen ben-schwen merged commit cffb4a1 into master Jan 21, 2025
10 of 11 checks passed
@ben-schwen ben-schwen deleted the deprec-with-set branch January 21, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants