Fix incorrect keying of by= results involving functions of keys#6708
Merged
MichaelChirico merged 7 commits intomasterfrom Jan 17, 2025
Merged
Fix incorrect keying of by= results involving functions of keys#6708MichaelChirico merged 7 commits intomasterfrom
MichaelChirico merged 7 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6708 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 79 79
Lines 14631 14642 +11
=======================================
+ Hits 14430 14441 +11
Misses 201 201 ☔ View full report in Codecov by Sentry. |
|
Generated via commit 3177ed1 Download link for the artifact containing the test results: ↓ atime-results.zip
|
tdhock
approved these changes
Jan 17, 2025
Member
tdhock
left a comment
tdhock
left a comment
There was a problem hiding this comment.
lgtm
i had no idea this was an issue.
there are so many special cases!
| # For #5583, we also ensure there are no function calls in by (which might break sortedness) | ||
| if (is.name(bysub)) return(TRUE) | ||
| if (identical(bysub[[1L]], quote(list))) bysub = bysub[-1L] | ||
| if (length(all.names(bysub)) > length(byvars)) return(FALSE) |
Member
There was a problem hiding this comment.
nice refactor and helper function name!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5583.
In principal this could be a breaking change for some user that has
by = .(a = foo(a))whereais the key andfoo()is weakly increasing.If we find any such case in revdeps, I will bump this change to 1.18.0 (there is a known workaround for the bug, i.e. use
keyby=, and the bug appears to have taken quite some time to surface) and push the breaking change in next release. As a breaking change, the fix is also trivial (switch tokeyby=).