Skip to content

feat : added condition to check the RHS of := #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
venom1204 wants to merge 13 commits into from
Closed

feat : added condition to check the RHS of := #6742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dbb7794
checking RHS of :=
venom1204 Jan 20, 2025
b333d52
Merge branch 'master' into issue5829
venom1204 Mar 7, 2025
6c8dd59
Merge branch 'Rdatatable:master' into issue5829
venom1204 Jun 6, 2025
49c52d0
added condition to check the rhs
venom1204 Jun 6, 2025
1d29473
added tests
venom1204 Jun 6, 2025
5f7f5ff
k
venom1204 Jun 6, 2025
8624ba1
Merge branch 'issue5829' of https://github.com/venom1204/data.table i…
venom1204 Jun 6, 2025
c9693bd
merged branch
venom1204 Jun 6, 2025
2dfd231
lint r
venom1204 Jun 6, 2025
2ded81a
lintr
venom1204 Jun 6, 2025
e50316a
updated
venom1204 Jun 8, 2025
3fe9173
Merge branch 'master' into issue5829
venom1204 Jun 10, 2025
b295e9b
removed the list check
venom1204 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions R/data.table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,15 +1403,18 @@ replace_dot_alias = function(e) {
}

if (!is.null(lhs)) {
# We only need to check if we are creating new columns.
newnames = setdiff(lhs, names(x))
if (length(newnames) > 0) {
if (is.function(jval)) {
stopf("RHS of `:=` is a function. To create a new column of functions, it must be a list column (e.g., wrap in `list()`).")
} else if (is.list(jval) && length(jval) == 1 && is.function(jval[[1L]])) {
stopf("RHS of `:=` is a length-1 list containing a function. `data.table` does not automatically recycle lists. To create a list-column, use `rep(list(myfun), .N)` to match the number of rows.")
if (length(cols) == 1L) {
is_new_col <- cols > ncol(x)
if (is_new_col || !is.list(x[[cols]])) {
if (is.function(jval)) {
stopf("RHS of `:=` is a function. To create a new column of functions or assign to a non-list-column, it must be wrapped in a list(), e.g., `:= list(myfun)`.")
}
if (is.list(jval) && length(jval) == 1L && is.function(jval[[1L]]) && nrow(x) > 1L) {
stopf("RHS of `:=` is a length-1 list containing a function. `data.table` does not automatically recycle lists. To create a list-column, use `rep(list(myfun), .N)`.")
Copy link
Member

@tdhock tdhock Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect.

> data.table(x=1:2, L=list(mean))
       x             L
   <int>        <list>
1:     1 <function[1]>
2:     2 <function[1]>

Copy link
Contributor Author

@venom1204 venom1204 Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi
i updated the condition and the tests, can you please review if something is missing/wrong ,when you have time.
thank you.

}
}
}
newnames = setdiff(lhs, names(x))
# TODO?: use set() here now that it can add new columns.Then remove newnames and alloc logic above.
.Call(Cassign,x,irows,cols,newnames,jval)
return(suppPrint(x))
Expand Down
7 changes: 6 additions & 1 deletion inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21161,4 +21161,9 @@ test(2317.9, DT1[DF2, on='a', .(e = x.a + i.e)]$e, 6)
DT = data.table(x = 1:3)

test(2318.1, DT[, y := mean], error = "RHS of `:=` is a function")
test(2318.2, DT[, y := list(mean)], error = "RHS of `:=` is a length-1 list containing a function")
test(2318.2, DT[, y := list(mean)], error = "RHS of `:=` is a length-1 list containing a function")
f = mean
test(2318.3, DT[, y := f], error = "RHS of `:=` is a function")
test(2318.4, DT[, y := identity(mean)], error = "RHS of `:=` is a function")
Copy link
Member

@tdhock tdhock Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHS is not a function here

test(2318.5, data.table(x = 1)[, y := mean], error = "RHS of `:=` is a function")
test(2318.6, data.table(x = 1:2)[, y := mean], error = "RHS of `:=` is a function")
Loading