Skip to content

Column naming for empty string and duplicate NA label #6795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Divendra2006 wants to merge 7 commits into from
Closed

Column naming for empty string and duplicate NA label #6795

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f820068
column naming for empty string and duplicate NA label
Divendra2006 Feb 3, 2025
6a4fe65
changes made
Divendra2006 Feb 4, 2025
5a47ce0
changes made
Divendra2006 Feb 18, 2025
e1fd079
changes made
Divendra2006 Feb 18, 2025
0586ffd
Merge branch 'master' into data
Divendra2006 Feb 18, 2025
b414ddc
changes made
Divendra2006 Feb 19, 2025
e52de3e
changes
Divendra2006 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion R/fcast.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,12 @@
value.var = names(data)[ncol(data)]
lvals = value_vars(value.var, names(data))
valnames = unique(unlist(lvals))
if (any(valnames == "")) {

Check warning on line 139 in R/fcast.R

View workflow job for this annotation

GitHub Actions / lint-r 

file=R/fcast.R,line=139,col=11,[nzchar_linter] Use !nzchar(x) instead of x == "". Note that unlike nzchar(), EQ coerces to character, so you'll have to use as.character() if x is a factor. Whenever missing data is possible, please take care to use nzchar(., keepNA = TRUE); nzchar(NA) is TRUE by default.
valnames[valnames == ""] = ""

Check warning on line 140 in R/fcast.R

View workflow job for this annotation

GitHub Actions / lint-r 

file=R/fcast.R,line=140,col=14,[nzchar_linter] Use !nzchar(x) instead of x == "". Note that unlike nzchar(), EQ coerces to character, so you'll have to use as.character() if x is a factor. Whenever missing data is possible, please take care to use nzchar(., keepNA = TRUE); nzchar(NA) is TRUE by default.

Check warning on line 140 in R/fcast.R

View check run for this annotation

Codecov / codecov/patch

R/fcast.R#L140 

Added line #L140 was not covered by tests
}
if (any(duplicated(valnames))) {

Check warning on line 142 in R/fcast.R

View workflow job for this annotation

GitHub Actions / lint-r 

file=R/fcast.R,line=142,col=7,[any_duplicated_linter] anyDuplicated(x, ...) > 0 is better than any(duplicated(x), ...).
valnames = make.unique(valnames, sep = sep)

Check warning on line 143 in R/fcast.R

View check run for this annotation

Codecov / codecov/patch

R/fcast.R#L143 

Added line #L143 was not covered by tests
}
lvars = check_formula(formula, names(data), valnames, value.var.in.LHSdots, value.var.in.RHSdots)
lvars = lapply(lvars, function(x) if (length(x)) x else quote(`.`))
# tired of lapply and the way it handles environments!
Expand Down Expand Up @@ -252,4 +258,4 @@
setDT(ans); setattr(ans, 'sorted', lhsnames)
} else internal_error("empty rhsnames") # nocov
return(ans)
}
}

Check warning on line 261 in R/fcast.R

View workflow job for this annotation

GitHub Actions / lint-r 

file=R/fcast.R,line=261,col=2,[trailing_blank_lines_linter] Add a terminal newline.
Loading