Skip to content

Conversation

@MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Feb 20, 2025

Uncovered by the new `coalesce_linter():

r-lib/lintr#2767

@MichaelChirico MichaelChirico added the code-quality Issues related to improving code quality/readability label Feb 20, 2025
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (05e3bdf) to head (6116e58).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6826   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          79       79           
  Lines       14661    14661           
=======================================
  Hits        14455    14455           
  Misses        206      206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

Comparison Plot

Generated via commit 6116e58

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 39 seconds
Installing different package versions 8 minutes and 13 seconds
Running and plotting the test cases 2 minutes and 20 seconds

@MichaelChirico MichaelChirico marked this pull request as ready for review March 4, 2025 07:38
@rikivillalba
Copy link
Contributor

there is a single instance of get0(... ifnotfound =...) if it is worth

R/data.table.R:1487: if (verbose && !get0('done_units_report', parent.frame(), ifnotfound = FALSE)) {

@MichaelChirico
Copy link
Member Author

Are you thinking to replace get0() with %||%, something like get("done_units_report", parent.frame()) %||% FALSE? I don't have an immediate preference either way... presumably get0() is a bit optimized...

@MichaelChirico MichaelChirico requested a review from tdhock March 6, 2025 21:49
Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I did not know about %||% but that is a nice trick

@MichaelChirico MichaelChirico merged commit fc43386 into master Mar 7, 2025
11 checks passed
@MichaelChirico MichaelChirico deleted the null-coalescing branch March 7, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality Issues related to improving code quality/readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants