Skip to content

fix rounding warning in atime test for [.data.table#7024

Merged
MichaelChirico merged 1 commit intomasterfrom
fix-N-round
May 26, 2025
Merged

fix rounding warning in atime test for [.data.table#7024
MichaelChirico merged 1 commit intomasterfrom
fix-N-round

Conversation

@tdhock
Copy link
Member

@tdhock tdhock commented May 26, 2025

I was getting an off by one warning due to rounding, which below is converted to error with options(warn=2)

> N <- 5623
> d <- data.table(
+ id = sample(c(seq.int(N * 0.9), sample(N * 0.9, N * 0.1, TRUE))),
+ v1 = sample(5L, N, TRUE),
+ v2 = sample(5L, N, TRUE)
+ )
Erreur dans as.data.table.list(x, keep.rownames = keep.rownames, check.names = check.names,  : 
  (converti depuis l'avis) L'élément 1 a 5622 lignes mais l'élément le plus long en a 5623 ; Il est recyclé avec le reste.

This PR fixes that warning.

@tdhock tdhock requested a review from Anirban166 as a code owner May 26, 2025 22:26
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (8647d44) to head (07f54a6).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7024   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          79       79           
  Lines       14677    14678    +1     
=======================================
+ Hits        14486    14487    +1     
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Comparison Plot

Generated via commit 07f54a6

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 21 seconds
Installing different package versions 8 minutes and 14 seconds
Running and plotting the test cases 1 minutes and 57 seconds

@MichaelChirico MichaelChirico merged commit 5f4258e into master May 26, 2025
11 checks passed
@MichaelChirico MichaelChirico deleted the fix-N-round branch May 26, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants