Skip to content

Allow tbl in i to use 'i.' and 'x.' prefixes in joins#7025

Merged
MichaelChirico merged 3 commits intomasterfrom
tbl-i
May 28, 2025
Merged

Allow tbl in i to use 'i.' and 'x.' prefixes in joins#7025
MichaelChirico merged 3 commits intomasterfrom
tbl-i

Conversation

@MichaelChirico
Copy link
Member

Closes #6998

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (b689cd2) to head (b7fce75).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7025   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          79       79           
  Lines       14676    14676           
=======================================
  Hits        14485    14485           
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented May 26, 2025

Comparison Plot

Generated via commit b7fce75

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 40 seconds
Installing different package versions 9 minutes and 15 seconds
Running and plotting the test cases 1 minutes and 51 seconds

@tdhock
Copy link
Member

tdhock commented May 28, 2025

cool!
I noticed a similar issue, #5564 which I thought may be fixed by this PR, but I just tested it, and it seems to still not work.

@tdhock
Copy link
Member

tdhock commented May 28, 2025

THanks, I approve but I don't see the approve review button for some reason.

@MichaelChirico MichaelChirico merged commit b07be17 into master May 28, 2025
9 checks passed
@MichaelChirico MichaelChirico deleted the tbl-i branch May 28, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DT[TBL, a:=i.b] update join with 'i.' prefix fails when 'i' is a tibble

2 participants