-
Notifications
You must be signed in to change notification settings - Fork 1k
removed macro internalErrSize
#7046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7046 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 79 79
Lines 14688 14689 +1
=======================================
+ Hits 14497 14498 +1
Misses 191 191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 99b86cf Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
I don't know why the tests are failing. Everything works fine on my end |
|
In the Microsoft Windows SDK, when compiling C code, <stdlib.h>
#defines the macros min() and max() in addition to the documented
Microsoft-specific macros __min() and __max() [1], unless __STDC__ is
pre-defined to a non-zero value (it's not) or _POSIX_ is defined
(neither it is). In MinGW, the SDK used by R on Windows as part of
Rtools [2], these definitions are disabled [3]; they are absent on
other systems.
[1]
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/min?view=msvc-170
[2]
https://cran.r-project.org/bin/windows/Rtools/
[3]
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/e1ff62d7f9acfbcb748e636f097fd2e6cc21d249/tree/mingw-w64-headers/crt/stdlib.h#l641
|

In the interest of continued improvements to readability, I've removed the unnecessary
internalErrSizemacro constant.