Skip to content

Conversation

@badasahog
Copy link
Contributor

In the interest of continued improvements to readability, I've removed the unnecessary internalErrSize macro constant.

@badasahog badasahog requested a review from aitap as a code owner June 4, 2025 13:55
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (d2b3ea7) to head (99b86cf).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7046   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          79       79           
  Lines       14688    14689    +1     
=======================================
+ Hits        14497    14498    +1     
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

  • HEAD=macroRemoval stopped early for DT[,.SD] improved in #4501
  • HEAD=macroRemoval slower P<0.001 for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit 99b86cf

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 53 seconds
Installing different package versions 38 seconds
Running and plotting the test cases 2 minutes and 28 seconds

@badasahog badasahog requested a review from aitap June 7, 2025 17:47
@badasahog
Copy link
Contributor Author

I don't know why the tests are failing. Everything works fine on my end

@aitap
Copy link
Member

aitap commented Jun 11, 2025 via email

@badasahog badasahog requested a review from MichaelChirico June 16, 2025 11:03
@badasahog badasahog requested a review from MichaelChirico June 29, 2025 19:13
@MichaelChirico MichaelChirico merged commit 6029f2f into master Jun 30, 2025
12 checks passed
@MichaelChirico MichaelChirico deleted the macroRemoval branch June 30, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants