Skip to content

droplevels works on 0-row tables#7131

Merged
ben-schwen merged 2 commits intomasterfrom
drop-empty-levels
Jul 7, 2025
Merged

droplevels works on 0-row tables#7131
ben-schwen merged 2 commits intomasterfrom
drop-empty-levels

Conversation

@MichaelChirico
Copy link
Member

Closes #7043

@MichaelChirico MichaelChirico requested a review from tdhock July 4, 2025 22:51
@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (1e2e3ba) to head (1efdaea).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7131   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          81       81           
  Lines       15013    15013           
=======================================
  Hits        14790    14790           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

  • HEAD=drop-empty-levels slower P<0.001 for memrecycle regression fixed in #5463
  • HEAD=drop-empty-levels slower P<0.001 for setDT improved in #5427
    Comparison Plot

Generated via commit 1efdaea

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 50 seconds
Installing different package versions 9 minutes and 20 seconds
Running and plotting the test cases 2 minutes and 25 seconds

@ben-schwen ben-schwen merged commit c446f2e into master Jul 7, 2025
12 checks passed
@ben-schwen ben-schwen deleted the drop-empty-levels branch July 7, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

droplevels() does not drop levels for empty data.tables

2 participants