Skip to content

Conversation

@badasahog
Copy link
Contributor

Hopefully no conflicts?

Once this is merged I'll get more aggressive with #6968 and #6971

@badasahog badasahog requested a review from MichaelChirico as a code owner July 7, 2025 11:42
@badasahog badasahog requested review from MichaelChirico and mattdowle and removed request for MichaelChirico July 7, 2025 11:42
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 97.12644% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.50%. Comparing base (c446f2e) to head (6c50dbc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/fwrite.c 96.82% 4 Missing ⚠️
src/fwriteR.c 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7135      +/-   ##
==========================================
- Coverage   98.51%   98.50%   -0.01%     
==========================================
  Files          81       81              
  Lines       15013    15015       +2     
==========================================
+ Hits        14790    14791       +1     
- Misses        223      224       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

No obvious timing issues in HEAD=fwriteReformat
Comparison Plot

Generated via commit 6c50dbc

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 54 seconds
Installing different package versions 21 seconds
Running and plotting the test cases 2 minutes and 36 seconds

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What was done this round to avoid the need for follow-up PRs? It makes the git history cleaner if we can avoid multiple "style-only" edits

@badasahog
Copy link
Contributor Author

@MichaelChirico I thought it was better to separate style out. I can add more in on top, in future PRs. Up to you.

@MichaelChirico
Copy link
Member

What I have in mind is #7106 / #7112, where we wound up with 3 commits doing ~the same formatting-only changes. Can we avoid that by using tooling to identify the changes needed, or otherwise taking another pass at the file now before merging?

@badasahog
Copy link
Contributor Author

I think this one is simpler, so that won't be needed.

I'll make sure to include other improvements with future PRs

@MichaelChirico MichaelChirico merged commit def1e47 into master Jul 7, 2025
10 of 12 checks passed
@MichaelChirico MichaelChirico deleted the fwriteReformat branch July 7, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants