Skip to content

Warn when by/keyby is used with column selection via character or numeric j #7254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Warn when by/keyby is used with column selection via character or numeric j #7254

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a5d68f3
added a warning
venom1204 Aug 16, 2025
ea5458b
..
venom1204 Aug 16, 2025
87b375f
corrected
venom1204 Aug 16, 2025
7b84533
lintr
venom1204 Aug 16, 2025
242847a
restructure
venom1204 Aug 20, 2025
418a74e
added backticks
venom1204 Aug 20, 2025
c2d84ed
..
venom1204 Aug 20, 2025
b150b0a
warningf
venom1204 Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions R/data.table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,17 +735,22 @@ replace_dot_alias = function(e) {
names(..syms) = ..syms
j = eval(jsub, lapply(substr(..syms, 3L, nchar(..syms)), get, pos=parent.frame()), parent.frame())
}
if (is.logical(j)) j = which(j)
if (!length(j) && !notj) return( null.data.table() )
if (is.factor(j)) j = as.character(j) # fix for FR: #358
if (is.character(j) || (is.numeric(j) && !is.logical(j))) {
if (!missingby) {
j_type = if (is.character(j)) "a character" else "a numeric"
warning(
Copy link
Member

@jangorecki jangorecki Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have warningf function that could be used here nicely

"`by` or `keyby` is ignored when `j` is ", j_type, " vector used for column selection. ",
"Perhaps you intended to use `.SD`? For example: DT[, .SD[, ", deparse(jsub), "], by = ...]",
call. = FALSE
)
}
}

if (is.logical(j)) j = which(j)

if (is.character(j)) {
if (!missingby) {
warning(
"`by` or `keyby` is ignored when `j` is a character vector used for column selection. ",
"Perhaps you intended to use `.SD`? For example: DT[, .SD[, ", deparse(jsub), "], by = ...]",
call. = FALSE
)
}
if (notj) {
if (anyNA(idx <- chmatch(j, names_x)))
warningf(ngettext(sum(is.na(idx)), "column not removed because not found: %s", "columns not removed because not found: %s"),
Expand All @@ -769,12 +774,6 @@ replace_dot_alias = function(e) {
# else the NA in ansvals are for join inherited scope (test 1973), and NA could be in irows from join and data in i should be returned (test 1977)
# in both cases leave to the R-level subsetting of i and x together further below
} else if (is.numeric(j)) {
if (!missingby) {
warning(
"`by` or `keyby` is ignored when `j` is a numeric vector used for column selection. ", "Perhaps you intended to use `.SD`? For example: DT[, .SD[, ", deparse(jsub), "], by = ...]",
call. = FALSE
)
}
j = as.integer(j)
if (any(w <- (j>ncol(x)))) stopf("Item %d of j is %d which is outside the column number range [1,ncol=%d]", idx <- which.first(w), j[idx], ncol(x))
j = j[j!=0L]
Expand Down
Loading