Skip to content

frollapply rewritten, by.column=F, parallel, any type #7272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jangorecki merged 24 commits into from
Sep 7, 2025
Merged

frollapply rewritten, by.column=F, parallel, any type #7272

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
996bce9
frollmax PRs 2:10
jangorecki May 26, 2025
7258909
frollmax PR as potentially complete
jangorecki May 26, 2025
09cc3ff
recoded frollapply but not split
jangorecki May 27, 2025
03980b2
frollapply rewritten, by.column=F, parallel, any type
jangorecki Aug 30, 2025
e12425f
address issues spot by lintr
jangorecki Aug 30, 2025
2c54ad2
fix codecov
jangorecki Aug 30, 2025
75b78d0
try possibly a fix for codecov bug?
jangorecki Aug 30, 2025
38355d4
codecov runs older R where is.atomic(NULL) was true, this should fix
jangorecki Aug 30, 2025
e8fb5f7
codecov last item
jangorecki Aug 30, 2025
c093310
Merge branch 'master' into frollapply2025
jangorecki Sep 1, 2025
519705d
add parallel to suggests
jangorecki Sep 2, 2025
9aad8bc
types.Rraw causes codecov to hang, try no parallel
jangorecki Sep 3, 2025
cf92fc2
manual codecov confirmation for nocov exceptions
jangorecki Sep 3, 2025
c4298cc
disabling openmp did not help, still stuck
jangorecki Sep 3, 2025
2370719
improve comments
jangorecki Sep 4, 2025
029c5af
use new argument name N
jangorecki Sep 4, 2025
8566c0c
fix codecov, temporary workaround
jangorecki Sep 4, 2025
42dcfe6
handle interrupts nicely
jangorecki Sep 4, 2025
0e0ce08
move interrupt handler just after child processes are created
jangorecki Sep 4, 2025
ee99600
duplicate error/warn templates for easier translation
jangorecki Sep 4, 2025
73b00b3
wrap messages with gettext
jangorecki Sep 5, 2025
b249f1b
frollapply test
Sep 5, 2025
04cd26a
rm perf test
tdhock Sep 6, 2025
ea19cf5
minor doc edits
jangorecki Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,20 @@ test.list <- atime::atime_test_list(
Slow = "e25ea80b793165094cea87d946d2bab5628f70a6" # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/60a01fa65191c44d7997de1843e9a1dfe5be9f72)
),

# Performance test based on system.time() code from https://github.com/Rdatatable/data.table/pull/7272#issue-3368806267
"frollapply improved in #7272" = atime::atime_test(
N=as.integer(10^seq(2, 7, by=0.2)),
setup={
set.seed(108)
setDTthreads(4)
x = rnorm(N)
},
seconds.limit=0.1,
expr=data.table::frollapply(x, as.integer(N/10), median),
Slow="8647d44646426d9045696890378c64f5dd239b07", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/996bce96c3c0e2920ae89af70e7258caf77340f6) in the PR (https://github.com/Rdatatable/data.table/pull/7272/commits)
Fast="73b00b3ceefd4d1bd683ab197ec7e09a4e2a2039" # Most recent commit in the PR when performance test was created on 2025-09-05.
),

# Performance regression discussed in https://github.com/Rdatatable/data.table/issues/4311
# Test case adapted from https://github.com/Rdatatable/data.table/pull/4440#issuecomment-632842980 which is the fix PR.
"shallow regression fixed in #4440" = atime::atime_test(
Expand Down
Loading