-
Notifications
You must be signed in to change notification settings - Fork 1k
fix installation using clang-17 #7318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tdhock
wants to merge
17
commits into
master
Choose a base branch
from
fix-macos-15-image
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
aabcee0
activate macos checks
d0cb5cc
try sysreqs
82ad4a0
cancel in progress false for testing
eca2984
try removing concurrency
354b8d3
rm fail-fast
7b0cde4
Install custom OpenMP runtime for Apple clang 17
aitap 80c14cd
configure: test OpenMP dynamic dispatch
aitap 8ff74db
GHA: rely on configure to pick up OpenMP runtime
aitap c519473
NEWS item
aitap 39beb9b
Revert "rm fail-fast"
aitap 020a89e
Revert "try removing concurrency"
aitap ffc4417
Revert "cancel in progress false for testing"
aitap 3504c51
configure: stronger check for OpenMP
aitap 9e19ef4
Update .github/workflows/R-CMD-check.yaml
aitap d0f4b30
Update .github/workflows/R-CMD-check.yaml
aitap 8a144cd
GHA: cache by runner architecture in addition to OS
aitap 5bd5505
Move the NEWS item to NOTES
aitap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted this line because I would like to have the macos-14 build run to completion/sucess as a positive control https://github.com/Rdatatable/data.table/actions/runs/17743367148/job/50422540824 but I still see macos-14 build gets cancelled as soon as macos-15 build fails. is there a way to configure that here? Or is the configuration from master branch overriding somehow?