Skip to content

rolling prod more accurate#7351

Merged
jangorecki merged 8 commits intomasterfrom
froll-prod2
Oct 9, 2025
Merged

rolling prod more accurate#7351
jangorecki merged 8 commits intomasterfrom
froll-prod2

Conversation

@jangorecki
Copy link
Member

@jangorecki jangorecki commented Sep 28, 2025

closes #7349

  1. handle 0 in prod fast
  2. adaptive prod fast redirects to exact
    while it feels ok for adaptive=T/F to have an impact on accuracy, the partial=T/F should not, and because of how partial is implemented, by redirect to adaptive, and because adaptive prod fast was suffering numerical stability due to cumulative prod (new tests added here also detects that), I decided to remove adaptive prod fast and use exact instead. Tips on possible implementation have been provided in the code.

@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (c5e8152) to head (d3fd47e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7351      +/-   ##
==========================================
- Coverage   99.11%   99.11%   -0.01%     
==========================================
  Files          85       85              
  Lines       16472    16443      -29     
==========================================
- Hits        16327    16298      -29     
  Misses        145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jangorecki jangorecki marked this pull request as draft October 3, 2025 20:59
@jangorecki jangorecki marked this pull request as ready for review October 8, 2025 18:47
@jangorecki jangorecki added this to the 1.18.0 milestone Oct 8, 2025
@jangorecki jangorecki merged commit 55b0de6 into master Oct 9, 2025
11 of 12 checks passed
@jangorecki jangorecki deleted the froll-prod2 branch October 9, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rolling product and numerical stability

1 participant