Skip to content

Conversation

@ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Oct 25, 2025

Closes #7336
Closes #1343
Closes #7333

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.13%. Comparing base (8ab0b2b) to head (fa5967f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7388   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          85       85           
  Lines       16577    16600   +23     
=======================================
+ Hits        16433    16456   +23     
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

  • HEAD=tests_requires_utf8 stopped early for DT[by,verbose=TRUE] improved in #6296
  • HEAD=tests_requires_utf8 slower P<0.001 for setDT improved in #5427
    Comparison Plot

Generated via commit fa5967f

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 44 seconds
Installing different package versions 21 seconds
Running and plotting the test cases 2 minutes and 53 seconds

@aitap
Copy link
Contributor

aitap commented Oct 25, 2025

Sorry if I'm late to note this, but wouldn't a more reliable test for this be the same thing as we currently use for ñ in test 2266? A test may require some symbols (ñ, ü, ん) to be representable in the native encoding. The symbols may be represented using Unicode escapes (\uXXXX) as they currently do. If !identical(foo, enc2native(foo)), then the test must be skipped.

@ben-schwen
Copy link
Member Author

The symbols may be represented using Unicode escapes (\uXXXX) as they currently do. If !identical(foo, enc2native(foo)), then the test must be skipped.

Good point. I have integrated this for the utf8_check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add argument like 'requires_utf8' to test() Escape UTF-8 dependent tests Finish DtNonAsciiTests package and submit to CRAN

3 participants