rework reference semantics of setDT and friends #7392
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-schwen
changed the title
Generated via commit 7049f9b Download link for the artifact containing the test results: ↓ atime-results.zip
|
jangorecki
reviewed
Oct 26, 2025
| } | ||
|
|
||
| setDT = function(x, keep.rownames=FALSE, key=NULL, check.names=FALSE) { | ||
| setDT = function(x, keep.rownames=FALSE, key=NULL, check.names=FALSE, duplicateShared=TRUE) { |
There was a problem hiding this comment.
I would keep naming style consistent here by naming duplicate.shared, or maybe just shared which would be the opposite of what current arg means, so then logic needs !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2683
Closes #4240
Closes #4783
Closes #4816
Closes #5330
Probably needs to investigate
#1218
#3959