Skip to content

Fix System Launcher Layout issues and exceptions #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Crypt0Beaver wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Fix System Launcher Layout issues and exceptions #1472

Crypt0Beaver wants to merge 45 commits into from

Conversation

@Crypt0Beaver
Copy link

@Crypt0Beaver Crypt0Beaver commented Dec 5, 2025 •
edited
Loading

Fixes some Home/System Launcher issues:

  • Crash with padding settings activated at the same time as custom grid size
  • Issues with OS3 Launcher (even if installed on a OS2 system):
    • Workspace Padding
    • CornerSlide
    • UnlockBlurSupported
    • Layout Calculation

#1370

@Crypt0Beaver
Refactor DisplayUtils to use Resources.getSystem()
7b68534
@Crypt0Beaver
Fix device config class selection logic
d8b5b9c
@Crypt0Beaver
Refactor initOS3Hook for new device configuration
53d2f04 
Added initOS3Hook method to initialize new device configuration for OS 3.
@Crypt0Beaver
Refactor initOS3Hook to use findClassIfExists
9a9c4fe
@Crypt0Beaver
Change initOS3Hook method from Kotlin to Java
b8f6dd5
@Crypt0Beaver
Comment out unused imports and methods in WorkspacePadding
3e85c61
@Crypt0Beaver
Refactor padding methods to use setDimensionPixelSizeFormPrefs
a550948
@Crypt0Beaver
Refactor workspace padding calculations
3504d16
@Crypt0Beaver
Remove unnecessary float conversion for padding
a61c932
@Crypt0Beaver
Refactor workspace padding calculations in LayoutRules
e451ae8
@Crypt0Beaver
Refactor workspace padding retrieval logic
d00a97a
@Crypt0Beaver
Fix padding calculations in LayoutRules.kt
a3ef37f
@Crypt0Beaver
Refactor padding retrieval for workspace layout
99c23d5
@Crypt0Beaver
Refactor layout rules for cell dimensions and padding
e85b16a
@Crypt0Beaver
Use getAppContext() for display metrics access
98a0ca1
@Crypt0Beaver
Use Resources.getSystem() for display metrics
c320b6c
@Crypt0Beaver
Refactor workspace top padding retrieval in LayoutRules
7b07e35
@Crypt0Beaver
Change mWorkspaceTopPadding to use getObjectFieldAs
fd27d25
@Crypt0Beaver
Add screen height to layout rules logging
bda381d
@Crypt0Beaver
Fix calculation of currentCellHeight with padding hooks
1cccd2c
@Crypt0Beaver
Refactor dp2px methods to use app context
6d60ad6 
Updated dp2px methods to use getAppContext() for retrieving display metrics, adding error handling for density retrieval.
@Crypt0Beaver
Fix logging in DisplayUtils for density retrieval
65cf8ad
@Crypt0Beaver
Integrate AndroidLogUtils for error logging
1a2182e
@Crypt0Beaver
Fix calculation of currentCellHeight with padding
7031b4a
@Crypt0Beaver
Add logging to dp2px method in DisplayUtils
ec10e4d 
Added logging for dip to px conversion in dp2px method.
@Crypt0Beaver
Fix logging format in DisplayUtils.java
8d4cd0a
@Crypt0Beaver
Add logging to dp2px method in DisplayUtils
b616ee9
@Crypt0Beaver
Replace AndroidLogUtils with XposedLogUtils
b283144
@Crypt0Beaver
Refactor workspace padding logic in LayoutRules
60b3a81 
Refactored workspace padding handling and updated logging.
@Crypt0Beaver
Refactor mWorkspaceTopPadding access method
c37e1a2
Crypt0Beaver and others added 15 commits December 6, 2025 22:02
@Crypt0Beaver
Add error handling and logging to conversion methods
17161ef
@Crypt0Beaver
Refactor logging of rules object in LayoutRules.kt
24fab2b
@Crypt0Beaver
Add logging for setDimensionPixelSizeFormPrefs
58f329f
@Crypt0Beaver
Modify workspace padding methods to use preference values
0b7e38c 
Updated methods to retrieve workspace padding values from preferences.
@Crypt0Beaver
Fix padding methods call to return dip and not pix
8f965ca
@Crypt0Beaver
Add preference handling for workspace padding dimensions
26c7859
Refactor workspace padding to use a common MethodHook factory
a09fa3d 
Replaced duplicated logic for hooking `getWorkspaceCellPaddingBottom`, `getWorkspaceCellPaddingTop`, and `getWorkspaceCellPaddingSide`.

A new private method, `GetPrefDimension`, now creates and returns a `MethodHook` instance. This simplifies the `initBaseCore` method by creating a reusable component that handles fetching the dimension from preferences, converting from dp to px if needed, and setting the method result.
Refactor UnlockBlurSupported to adapt to OS3 Launcher
e0b6f4a
Refactor UnlockBlurSupported to adapt to OS3 Launcher
133d22b
Code cleanup
cc74e51
Code cleanup
634bd79
Code cleanup
54ba48f
Code cleanup
5b40278
Fix CornerSlide Module exception
7cdcd2f
Fix CornerSlide Module exception
ccf93f3 
Adapt to match HOS v2 and v3 signatures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Crypt0Beaver