Use auth middleware and remove userId from save route#230
Open
Use auth middleware and remove userId from save route#230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the POST /api/save route to use authentication middleware (protect) instead of accepting userId in the request body. The authenticated user's ID is now securely extracted from the JWT token.
Changes:
Applied protect middleware to /api/save route
Removed userId from client request body
Extracted userId from req.user (populated via verified token)
Preserved existing error handling and Prisma logic
Why:
To prevent unauthorized users from saving pins on behalf of other users and to follow security best practices by trusting only verified user identities.