Add retry with exponential backoff for PVGIS API calls #5
+306
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap all pybuildingenergy simulation calls that use weather_source="pvgis" with a retry decorator (3 attempts, exponential backoff) to handle transient network failures from the EU PVGIS API.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable retry decorator with exponential backoff and applies it to PVGIS-backed pybuildingenergy simulation calls to better handle transient PVGIS network failures.
Changes:
- Introduce
retry_on_transient_errordecorator utility (configurable retries + exponential backoff). - Wrap PVGIS simulation calls in
main.pyandforecasting_service_functions.pywith the retry decorator. - Add logging around transient failures and retry attempts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/relife_forecasting/utils/retry.py |
New retry/backoff decorator intended to make external API calls (PVGIS) more resilient. |
src/relife_forecasting/routes/forecasting_service_functions.py |
Wrap PVGIS simulation worker call with the retry decorator. |
src/relife_forecasting/main.py |
Wrap PVGIS simulation calls in API endpoints with the retry decorator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Add parameter validation (max_retries >= 1, initial_delay >= 0, backoff_factor > 0) - Make decorator async-aware to avoid blocking event loop with time.sleep - Add missing retry wrapper for PVGIS call in /ecm_application/run_sequential_save - Add comprehensive test coverage for retry utilities Addresses: - Review comment about invalid parameters causing TypeError - Review comment about blocking event loop in async contexts - Review comment about missing PVGIS retry wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap all pybuildingenergy simulation calls that use
weather_source="pvgis"with a retry decorator (multiple attempts and exponential backoff) to handle transient network failures from the EU PVGIS API.