-
-
Notifications
You must be signed in to change notification settings - Fork 3
build: Use Gradle credentials system #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the GitHub Packages authentication by switching from manual credential handling to Gradle's built-in PasswordCredentials system. This simplifies the configuration and follows Gradle best practices.
Key Changes:
- Replaced manual credential configuration with PasswordCredentials in settings.gradle.kts
- Updated GitHub Actions workflows to use ORG_GRADLE_PROJECT_* environment variables for credential injection
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| settings.gradle.kts | Simplified Maven repository credentials by using PasswordCredentials instead of manual property lookups |
| .github/workflows/release.yml | Updated environment variables to use ORG_GRADLE_PROJECT_* convention for Gradle property injection |
| .github/workflows/build_pull_request.yml | Updated environment variables to use ORG_GRADLE_PROJECT_* convention for Gradle property injection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Note Migrated to Note Migrated to Tracking:
|
oSumAtrIX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not merge yet, since env vars have to be configured in github
Switch to PasswordCredentials when during authentication with ghcr
nts: