Skip to content

Conversation

@validcube
Copy link
Member

@validcube validcube commented Dec 16, 2025

Switch to PasswordCredentials when during authentication with ghcr

nts:

githubPackagesUsername=
githubPackagesPassword=

@validcube validcube marked this pull request as ready for review December 19, 2025 14:20
Copilot AI review requested due to automatic review settings December 19, 2025 14:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the GitHub Packages authentication by switching from manual credential handling to Gradle's built-in PasswordCredentials system. This simplifies the configuration and follows Gradle best practices.

Key Changes:

  • Replaced manual credential configuration with PasswordCredentials in settings.gradle.kts
  • Updated GitHub Actions workflows to use ORG_GRADLE_PROJECT_* environment variables for credential injection

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
settings.gradle.kts Simplified Maven repository credentials by using PasswordCredentials instead of manual property lookups
.github/workflows/release.yml Updated environment variables to use ORG_GRADLE_PROJECT_* convention for Gradle property injection
.github/workflows/build_pull_request.yml Updated environment variables to use ORG_GRADLE_PROJECT_* convention for Gradle property injection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@validcube
Copy link
Member Author

validcube commented Dec 28, 2025

Note

Migrated to 0901 changelist (use consistent casing from GitHubPackages -> githubPackages)

Note

Migrated to 2001 changelist (CI cleanup)

Tracking:

Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge yet, since env vars have to be configured in github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants