Skip to content

Conversation

Aunali321
Copy link
Contributor

No description provided.

@oSumAtrIX
Copy link
Member

Got a screenshot of how it looks like/where this function is added

@Aunali321
Copy link
Contributor Author

Screenshot_20250817_010855_ReVanced Manager (Development) Screenshot_20250817_010849_ReVanced Manager (Development)

@oSumAtrIX
Copy link
Member

the view model needs to be parametrized to not include the checkmark or allow editing options. basically a readonly param

@Ushie
Copy link
Member

Ushie commented Aug 16, 2025

pov main branch

@brosssh brosssh changed the base branch from main to dev August 16, 2025 20:19
@Aunali321
Copy link
Contributor Author

Aunali321 commented Aug 17, 2025

the view model needs to be parametrized to not include the checkmark or allow editing options. basically a readonly param

Usually i would agree but this repo is so close to depreciation that it shouldn't be considered. I tried to achieve it with as low code as possible.

Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞👨‍💻 Close enough, welcome back cossale to the team. :trollface:

@Aunali321 Aunali321 requested a review from validcube August 17, 2025 22:14
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo is so close to depreciation that it shouldn't be considered. I tried to achieve it with as low code as possible.

Regardless, the change should be done, its merely a couple of if statements based on an injected boolean to hide UIs

@@ -73,6 +73,14 @@ class _NotInstalledAppItem extends State<NotInstalledAppItem> {
),
],
),
Text(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI language doesnt match with the rest of the surrounding UI. Please resolve this with e.g. @validcube

@Aunali321
Copy link
Contributor Author

Screenshot_20250819_141937_ReVanced Manager (Debug) Screenshot_20250819_141927_ReVanced Manager (Debug)

@validcube
Copy link
Member

I don't have access to Figma for more than a week now, I don't have my perfect opinion to this.

But I would immediately assume that having a "Tap to view patches" is redundant, why not make a dialog when you select an not installed app said something along the line of ...

image

@Aunali321
Copy link
Contributor Author

i feel like that would be too long. and cancel/ok doesn't make sense because there is nothing to cancel there

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Sep 1, 2025

Since tap to view patches is now added, the list of patches should be moved somewhere near to it. Right now its in the title next to the app name, it should be moved to a line for example:

View patches (1)

@validcube validcube requested a review from PalmDevs September 6, 2025 07:22
@validcube
Copy link
Member

cc: @PalmDevs UI/UX

@PalmDevs
Copy link
Member

PalmDevs commented Sep 7, 2025

But I would immediately assume that having a "Tap to view patches" is redundant, why not make a dialog when you select an not installed app said something along the line of ...

I think having dialog blocking an action that isn't destructive isn't ideal. I'd simply show a highlighted card at the top of the page with similar contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants