-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix: Adjust ReVanced icons #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can be merged long ago, not sure if any of the requested changes still hold today considering everything is mathematically sized to Android recommended grid. (Although my opinion is we shouldn't follow the grid at all because the grid assumed the icon is mostly square/circle shape and not elongated triangle)
|
I remember I had issues with the PR, so I'll review it before merging |
Actually scratch that |
validcube
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason to use density defined resolutions, we already have a much better way in mipmap-anyapi, Android will scale down/up as needed automatically.
Contination of #2762
Fix incorrect icon logo, #1124 and
Splash screen is a broken in light modefrom #1191 (comment)Round/Adaptive icon
Monochrome icon
Splash screen