Skip to content

Conversation

@oSumAtrIX
Copy link
Member

Contination of #2762


Fix incorrect icon logo, #1124 and Splash screen is a broken in light mode from #1191 (comment)


Round/Adaptive icon

Before (xxhdpi) After (xxhdpi)
ic_launcher ic_launcher

Monochrome icon

Screenshot_2025-10-02-18-29-17-092_app.lawnchair-edit.jpg


Splash screen

Dark Light
Screenshot_2025-10-04-08-35-24-375_app.revanced.manager.debug_signed.jpg Screenshot_2025-10-04-08-35-53-276_app.revanced.manager.debug_signed.jpg

@oSumAtrIX oSumAtrIX changed the base branch from main to dev December 21, 2025 22:08
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be merged long ago, not sure if any of the requested changes still hold today considering everything is mathematically sized to Android recommended grid. (Although my opinion is we shouldn't follow the grid at all because the grid assumed the icon is mostly square/circle shape and not elongated triangle)

@oSumAtrIX oSumAtrIX marked this pull request as draft December 26, 2025 11:51
@oSumAtrIX
Copy link
Member Author

I remember I had issues with the PR, so I'll review it before merging

@validcube
Copy link
Member

This PR can be merged long ago, not sure if any of the requested changes still hold today considering everything is mathematically sized to Android recommended grid. (Although my opinion is we shouldn't follow the grid at all because the grid assumed the icon is mostly square/circle shape and not elongated triangle)

Actually scratch that

Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no reason to use density defined resolutions, we already have a much better way in mipmap-anyapi, Android will scale down/up as needed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants