Skip to content

Comments

feat: Add patch selection filters#2956

Open
Aunali321 wants to merge 1 commit intoReVanced:devfrom
Aunali321:feat/patch-selection-filters
Open

feat: Add patch selection filters#2956
Aunali321 wants to merge 1 commit intoReVanced:devfrom
Aunali321:feat/patch-selection-filters

Conversation

@Aunali321
Copy link
Contributor

Closes #2955

recording.mp4

The existing restore defaults FAB (above the save button) may now be redundant since "Restore default selection" is available in the bottom sheet actions. Should we remove it, or keep it for quick access? Note that the FAB also resets patch options, while the new action only resets selection.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Feb 21, 2026

The popup currently asks for this vs all patches by using buttons to click. Perhaps a radio button is more fit?

We have an internal design branch, which would otherwise take care of things like this, so doesn't matter too much

@oSumAtrIX
Copy link
Member

The FAB should be removed. I think having multiple ways to do things in such close places adds unnecessary redundancy. Perhaps an orange • (dot) could be shown next to the filter button and next to the filter cards' reset to default button, when the defaults were changed, nagging the user to use the default selection, so the visibility question is resolved this way.

The patch options I am not sure how to solve. The filters are made for patches list. Perhaps clicking reset could show radio buttons for all/current patches/except this patches and a checkmark "also apply to options"

@planshim @Axelen123 @Ushie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants