-
-
Notifications
You must be signed in to change notification settings - Fork 617
fix(Prime Video): Update Skip ads patch
#6294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
patches/src/main/kotlin/app/revanced/patches/primevideo/ads/Fingerprints.kt
Outdated
Show resolved
Hide resolved
|
Regarding the pre-roll, should that be considered in this PR? |
Yeah, you can probably mark this as draft until its handled. I just didn't want to keep debugging without a consistent reproduction. |
|
Most definitely, well I suppose visibility will be a problem for those that would like to input on that |
patches/src/main/kotlin/app/revanced/patches/primevideo/ads/SkipAdsPatch.kt
Outdated
Show resolved
Hide resolved
6a194d5 to
d18941c
Compare
|
I am on version v3.0.430.1747 with the Skip Ads and Rename Shared Permissions patch. I can confirm that all ads except the first one at the very beginning get skipped. I still see about half a second of the ad frame, but thats fine. The way I reproduced the initial ad was by closing the app then removing it from recent apps, and relaunching it. |
|
@Not4GoodBoyThou what country was your IP address in when this shows up? The issue might be region specific. |
India |
This should be backwards compatible, so I removed the existing version constraint. Tested on latest (
v3.0.430.1747) if you want to add it back.There is an outstanding issue where occasionally the pre-roll ad plays instead of being skipped. If someone can help me consistently reproduce it, that would help my debugging efforts.