Skip to content

fix(Prime Video): Update Skip ads patch #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix(Prime Video): Update Skip ads patch #6294

wants to merge 1 commit into from
+25 −16

Conversation

@hoo-dles
Copy link
Contributor

@hoo-dles hoo-dles commented Nov 15, 2025

This should be backwards compatible, so I removed the existing version constraint. Tested on latest (v3.0.430.1747) if you want to add it back.

There is an outstanding issue where occasionally the pre-roll ad plays instead of being skipped. If someone can help me consistently reproduce it, that would help my debugging efforts.

@hoo-dles hoo-dles changed the base branch from main to dev November 15, 2025 00:16
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 15, 2025

Regarding the pre-roll, should that be considered in this PR?

@hoo-dles
Copy link
Contributor Author

hoo-dles commented Nov 15, 2025

Regarding the pre-roll, should that be considered in this PR?

Yeah, you can probably mark this as draft until its handled. I just didn't want to keep debugging without a consistent reproduction.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 15, 2025

Most definitely, well I suppose visibility will be a problem for those that would like to input on that

@oSumAtrIX oSumAtrIX marked this pull request as draft November 15, 2025 00:44
@hoo-dles
Squash
d18941c 
fix(Prime Video): Update `Skip ads` patch

Truncating class names in fingerprints

PR comments

fix(Prime Video): Update `Skip ads` patch

Truncating class names in fingerprints

Typo

PR comments
@Not4GoodBoyThou
Copy link

Not4GoodBoyThou commented Nov 18, 2025

I am on version v3.0.430.1747 with the Skip Ads and Rename Shared Permissions patch. I can confirm that all ads except the first one at the very beginning get skipped. I still see about half a second of the ad frame, but thats fine. The way I reproduced the initial ad was by closing the app then removing it from recent apps, and relaunching it.

logcat_2025-11-18_14-40-43.txt

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Nov 18, 2025

@Not4GoodBoyThou what country was your IP address in when this shows up? The issue might be region specific.

@Not4GoodBoyThou
Copy link

Not4GoodBoyThou commented Nov 18, 2025

@Not4GoodBoyThou what country was your IP address in when this shows up? The issue might be region specific.

India

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX left review comments

@LisoUseInAIKyrios LisoUseInAIKyrios LisoUseInAIKyrios left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoo-dles @oSumAtrIX @Not4GoodBoyThou @LisoUseInAIKyrios