generated from ReVanced/revanced-patches-template
-
-
Notifications
You must be signed in to change notification settings - Fork 617
feat(Letterboxd): Add Hide ads patch
#6309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Swakshan
wants to merge
4
commits into
ReVanced:dev
Choose a base branch
from
Swakshan:feat/letterboxd/hide-ads
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e47f14a
feat(Letterboxd): Added `Hide ads` patch
Swakshan 99f413e
Apply suggestion from @oSumAtrIX
oSumAtrIX 7a02855
feat(Letterboxd): `Hide ads` - turn on by default
Swakshan 76bd0a0
feat(Letterboxd): `Hide ads` - set fingerprints as internal
Swakshan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
patches/src/main/kotlin/app/revanced/patches/letterboxd/ads/Fingerprints.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package app.revanced.patches.letterboxd.ads | ||
|
|
||
| import app.revanced.patcher.fingerprint | ||
|
|
||
| internal const val admobHelperClassName = "Lcom/letterboxd/letterboxd/helpers/AdmobHelper;" | ||
|
|
||
| val admobHelperSetShowAdsFingerprint = fingerprint { | ||
| custom { method, classDef -> | ||
| method.name == "setShowAds" && classDef.type == admobHelperClassName | ||
| } | ||
| } | ||
|
|
||
| val admobHelperShouldShowAdsFingerprint = fingerprint { | ||
| custom { method, classDef -> | ||
| method.name == "shouldShowAds" && classDef.type == admobHelperClassName | ||
| } | ||
| } | ||
|
|
||
| val filmFragmentShowAdsFingerprint = fingerprint { | ||
| custom { method, classDef -> | ||
| method.name == "showAds" && classDef.type.endsWith("/FilmFragment;") | ||
| } | ||
| } | ||
|
|
||
| val memberExtensionShowAdsFingerprint = fingerprint { | ||
| custom { method, classDef -> | ||
| method.name == "showAds" && classDef.type.endsWith("/AMemberExtensionKt;") | ||
| } | ||
| } | ||
22 changes: 22 additions & 0 deletions
22
patches/src/main/kotlin/app/revanced/patches/letterboxd/ads/HideAdsPatch.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
|
|
||
| package app.revanced.patches.letterboxd.ads | ||
|
|
||
| import app.revanced.patcher.extensions.InstructionExtensions.addInstruction | ||
| import app.revanced.patcher.patch.bytecodePatch | ||
| import app.revanced.util.returnEarly | ||
|
|
||
| @Suppress("unused") | ||
| val hideAdsPatch = bytecodePatch( | ||
| name = "Hide ads", | ||
| ) { | ||
| compatibleWith("com.letterboxd.letterboxd") | ||
|
|
||
| execute { | ||
| admobHelperSetShowAdsFingerprint.method.addInstruction(0, "const p1, 0x0") | ||
LisoUseInAIKyrios marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Make the methods always return false. | ||
| listOf(admobHelperShouldShowAdsFingerprint, filmFragmentShowAdsFingerprint, memberExtensionShowAdsFingerprint).forEach { | ||
| it.method.returnEarly(false) | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.