Patches for Continuum to pretend to be RedReader#6487
Patches for Continuum to pretend to be RedReader#6487mike951921 wants to merge 1 commit intoReVanced:mainfrom
Conversation
user agent to pretend to be RedReader
|
The patch needs to be a abstracted for other reddit client as well. There's already such an abstract patch that can be changed for this purpose |
|
Also, no hardcoding of any keys ideally. Instead, patch options, then they can be set by the user to whatever values. The patch can technically even extract the details out of a supplied apk |
|
Ideally, this should target Infinity rather than Continuum. The motivation for the fork is to add support for user-provided API keys. Since Reddit has restricted the ability to generate new keys, I doubt the maintainer of Continuum will continue to synchronize with the upstream codebase. They also explicitly said that they won't add the ability to spoof User-Agent, redirect url, etc (see: cygnusx-1-org/continuum#195). By targeting Infinity, we can still rely on the original codebase while applying this patch. Honestly over all the third-party client I still prefer Infinity. |
|
Would it be possible to add other apps api keys support too, as for instance i have a api made for infinity, but to use it in continuum, i need to change the URI of the api. |
|
check this #6487 (comment)
|
According to #6487 (comment) the abstraction of the patch would allow any app to be patched with a custom client id |
I am a Continuum user without a Continuum client ID, and I want to enable others to use Continuum. So I have no intent to make this work for Infinity for Reddit. |
|
The patch should be abstracted regardless in a way where code is reusable in the codebase without the overhead of refactoring to prevent tech debt |
Say more, because this sounds just like a lot more work for no good reason. |
This is doable, but you are missing that the goal isn't to pretend to be any client. The goal is to pretend to be RedReader, which makes it just work without any user input. |
|
The same as the current client spoof patch by having a base patch parametrized for the respective apps. This isnt much work given you implement it for one app for now, and it has good reason as well which i showed in my previous comment |
This isnt flexible enough. With a patch option you can add a default value which hardcodes redreaders and other apps apis, that would satisfy the flexibility requirement, once again to prevent future tech debt |
Does the patch cover redirect uri and user agent? You are assuming I know what you are talking about. Explain what the other patch does in full. |
|
What you actually want is to modify the existing base spoof client patch. Right now it just spoofs the client id by passing the respective patch code as a parameter for the respective app. You can simply change the patch a little to add the other relevant stuff to spoof such as the redirect uri and user agent. To a certain extent this patch did that in the past for some apps that needed it. |
|
I just checked the code, there is a looot going on than it should. Checking. |
| dependsOn( | ||
| redditApiResourcePatch, | ||
| // Use regex-based replacement for user agent to work across all versions | ||
| transformInstructionsPatch( |
There was a problem hiding this comment.
- Do we really need this? Instead, just fingerprint the method where the UA is built, isnt that enough?
|
|
||
| val redditApiResourcePatch = resourcePatch( | ||
| name = "Reddit API override (resource)", | ||
| description = "Overrides Reddit client ID in strings.xml", |
There was a problem hiding this comment.
Why not just patch the bytecode that obtains the default client id string
| @Suppress("unused") | ||
| val removeClientIdCheckPatch = bytecodePatch( | ||
| name = "Remove client ID check", | ||
| description = "Removes the dialog that prevents login with default client ID", |
There was a problem hiding this comment.
The entire PR can be simplified a little. Instead of this, simply patch the code that actually makes the api calls or the place where the client id etc is saved. This way whatever the user enters, it would be overwritten by the patch.
There was a problem hiding this comment.
The spoof client base patch can be adjusted to not just only spoof the client id, but also the redirect uri and user agent. Parametrize/adjust that patch accordingly. Then, implement it for continuum, done.
Continuum IS Infinity, they haven't diverged enough to be considered separate. The only significant patch in Continuum is the ability to set custom API/client ID |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
4 participants
Added patches for Continuum to change the client id, redirect uri, and user agent to pretend to be RedReader