fix(TikTok): Vibe updated TikTok/Musically patch compatibility to 43.6.2#6535
fix(TikTok): Vibe updated TikTok/Musically patch compatibility to 43.6.2#6535X41 wants to merge 1 commit intoReVanced:devfrom
Conversation
| // TikTok 43.6.2: Lcom/ss/android/ugc/aweme/feed/api/FeedApi;->LIZIZ(LX/0Qft;)Lcom/ss/android/ugc/aweme/feed/model/FeedItemList; | ||
| accessFlags(AccessFlags.PUBLIC, AccessFlags.STATIC) | ||
| returns("Lcom/ss/android/ugc/aweme/feed/model/FeedItemList;") | ||
| parameters("LX/0Qft;") |
There was a problem hiding this comment.
This is not very maintainable, obfuscated names should not be in fingerprints, because they are likely different in every app version.
|
An LLM was guided here, the PR will need to be tested against the app to make sure it actually works anyways |
|
I saw this when it was released and made my own attempt at it. I took a different approach and worked off the v36 version to make as minimal changes as possible. I don't plan to make a PR because it is only for my use (and has hard coded settings), and I don't have the time to really flesh it out. If anyone finds it useful, here is my attempt at v43.8.3 lbux@0ad2464 I did not fix the settings patch and I was unable to make the remember speed patch to work. I also copied some of the filtering logic from this PR because that actually turned out to be fine. Everything else has too obfuscated and/or too overengineered. I also didn't touch the remember clear display patch because it compiled fine, but it will eventually crash like this attempt #4920 I can confirm downloads, feed filtering (except by like/view count), share, seekbar, and everything else works not mentioned above. Howerver, like this PR, it seems like Tiktok has done some weird changes to the way downloads work where sometimes they download as null files. This doesnt happen all the time, but I think it has something to do with the attempt to get the file without the watermark remotely returns null and we still attempt to download. I think my fork would be a better starting point than this PR if anyone wanted to work on this PR. Edit: I ended up implementing my own filtering logic and changing the way feed filters work + adding a bloat filter. Full changes are in the dev branch https://github.com/lbux/revanced-patches/tree/dev |
I got sick of the patches only working on 36.5.4 and the other modded tiktok apps being kind of awful, but i also wasn't motivated enough to dig into this myself so i guided an LLM to do it for me and additionally add some debug logging over the course of an evening.
i gave everything a try and used the app for a while with no issues, hope this is as stable as it feels
here's the summary the LLM whipped up:
What broke (43.6.2)
NoSuchMethodErrorbecauseAwemeno longer exposesisLive()/isImage()/isPhotoMode()in 43.6.2.Changes
Feed filter (patch + extension)
FeedItemList.getItems()so filtering runs regardless of which pipeline produced the feed list (incl. cache).AwemeAPI:getLiveId()/getLiveType()(+isLiveReplay()).getImageInfos()andgetPhotoModeImageInfo()/getPhotoModeTextInfo().getShareUrl()in ShopFilter.Settings entry (43.6.2)
Enable Open Debugthat re-enables TikTok’s hidden “Open debug” row, renames it to “ReVanced settings”, swaps the icon to a gear, and wires the click to open ReVanced settings viaAdPersonalizationActivityusing a dedicated intent action (revanced_settings).TikTokActivityHook.initialize()to also accept therevanced_settingsintent action (not only marker extras).Settingspatchuse=falsefor now (Compose settings redesign makes the previous entry injection unstable on 43.6.2).Debug logging (opt-in)
Misc
patches.apifor the new patch entry.