Skip to content

feat: Add announcements#257

Merged
Ushie merged 184 commits intoReVanced:devfrom
madkarmaa:feat/announcements
Jun 2, 2025
Merged

feat: Add announcements#257
Ushie merged 184 commits intoReVanced:devfrom
madkarmaa:feat/announcements

Conversation

@madkarmaa
Copy link
Member

@madkarmaa madkarmaa commented Sep 8, 2024

What's this?

This is a new, more updated continuation of #195

TODO:

@madkarmaa madkarmaa self-assigned this Sep 8, 2024
@oSumAtrIX oSumAtrIX mentioned this pull request Sep 8, 2024
5 tasks
@Ushie Ushie changed the title feat: announcements feat: Announcements Sep 8, 2024
@Ushie
Copy link
Member

Ushie commented Dec 19, 2024

Nullability is not handled properly

ReVanced API seems to also not respect it

Creation:
image

Result:
image

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Dec 20, 2024

Deleting tags does not behave like when creating a new announcement, they should disappear once unchecked

It has nothing to do with whether or not you're creating an announcement

Tags that already exist in the API will not disappear, tags that you've created in that draft will disappear once unchecked

Even if they don't disappear in the API, they do for the announcement itself. So if you uncheck a tag, it should be removed. Adding it back via the same name, would not create a new tag because it already exists. This behaviour is the same as on YouTube if you tag videos.

Unread latest announcement should be shown as a banner on the website.

The banners PR is not complete

In that case it should be looked into so that this PR can rebase onto it.

ReVanced API seems to also not respect it

The tags and attachments fields are non nullable. However I'll change that. For author the issue still applies (and once the other fields are nullable, there too)

@oSumAtrIX oSumAtrIX self-requested a review January 29, 2025 19:25
@oSumAtrIX oSumAtrIX marked this pull request as draft January 29, 2025 19:25
Ushie and others added 3 commits February 21, 2025 02:34
"A site’s URL structure should be as simple as possible. Consider organizing your content so that URLs are constructed logically and in a manner that is most intelligible to humans." — Google Search Central
@madkarmaa madkarmaa requested a review from Ushie March 8, 2025 19:37
@Ushie Ushie marked this pull request as ready for review May 23, 2025 00:27
@Ushie Ushie marked this pull request as draft May 23, 2025 00:27
@Ushie Ushie marked this pull request as ready for review June 2, 2025 23:10
@Ushie Ushie merged commit c224285 into ReVanced:dev Jun 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants