Add CanteraWriter #2870
Open
Add CanteraWriter #2870
+1,074
−291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongd
force-pushed
the
ct3
branch
2 times, most recently
from
a0983b8 to
24205ac
Compare
instead of the old from CTI
This breaks the circular dependency chain (simulate -> diffusionLimited -> Species -> pdep -> Reaction -> diffusionLimited) because diffusionLimited can now fully initialize before loading Species.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Currently RMG outputs a Cantera YAML file only after it converges, using the external ck2yaml script.
Sometimes the script fails, and sometimes if RMG doesn't converge, the model might still be useful as an intermediate step to assess the development status.
Description of Changes
A CanteraWriter module was added
Testing
Tests were added